From: Jonathan Corbet <corbet@lwn.net>
To: Daniel Bristot de Oliveira <bristot@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Cc: bristot@redhat.com, kcarcia@redhat.com,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
Clark Willaims <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH 5/5] tracing: Add the osnoise tracer
Date: Thu, 08 Apr 2021 09:58:04 -0600 [thread overview]
Message-ID: <87pmz422gj.fsf@meer.lwn.net> (raw)
In-Reply-To: <3a69303b27bfc5d2274ab893b2cfbd0a8dbe31f7.1617889883.git.bristot@redhat.com>
Daniel Bristot de Oliveira <bristot@redhat.com> writes:
A quick nit:
> Documentation/trace/osnoise_tracer.rst | 149 ++
> include/linux/ftrace_irq.h | 16 +
> include/trace/events/osnoise.h | 141 ++
> kernel/trace/Kconfig | 34 +
> kernel/trace/Makefile | 1 +
> kernel/trace/trace.h | 9 +-
> kernel/trace/trace_entries.h | 27 +
> kernel/trace/trace_osnoise.c | 1714 ++++++++++++++++++++++++
> kernel/trace/trace_output.c | 72 +-
> 9 files changed, 2159 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/trace/osnoise_tracer.rst
> create mode 100644 include/trace/events/osnoise.h
> create mode 100644 kernel/trace/trace_osnoise.c
When you create a new RST file, you need to add it to an index.rst (or
similar) file so that it gets incorporated into the docs build.
The document itself looks good on a quick read. If you're making
another pass over it, you might consider reducing the ``markup noise`` a
bit; we try to keep that to a minimum in the kernel docs. But otherwise
thanks for writing it!
jon
next prev parent reply other threads:[~2021-04-08 15:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 14:13 [RFC PATCH 0/5] hwlat improvements and osnoise tracer Daniel Bristot de Oliveira
2021-04-08 14:13 ` [RFC PATCH 1/5] tracing/hwlat: Add a cpus file specific for hwlat_detector Daniel Bristot de Oliveira
2021-04-14 14:10 ` Steven Rostedt
2021-04-15 13:09 ` Daniel Bristot de Oliveira
2021-04-15 13:49 ` Steven Rostedt
2021-04-15 14:33 ` Daniel Bristot de Oliveira
2021-04-08 14:13 ` [RFC PATCH 2/5] tracing/hwlat: Implement the mode config option Daniel Bristot de Oliveira
2021-04-14 14:30 ` Steven Rostedt
2021-04-15 13:16 ` Daniel Bristot de Oliveira
2021-04-15 13:50 ` Steven Rostedt
2021-04-08 14:13 ` [RFC PATCH 3/5] tracing/hwlat: Implement the per-cpu mode Daniel Bristot de Oliveira
2021-04-14 14:41 ` Steven Rostedt
2021-04-15 13:22 ` Daniel Bristot de Oliveira
2021-04-15 15:22 ` Steven Rostedt
2021-04-08 14:13 ` [RFC PATCH 4/5] tracing: Add __print_ns_to_secs() and __print_ns_without_secs() helpers Daniel Bristot de Oliveira
2021-04-08 14:13 ` [RFC PATCH 5/5] tracing: Add the osnoise tracer Daniel Bristot de Oliveira
2021-04-08 15:58 ` Jonathan Corbet [this message]
2021-04-09 7:19 ` Daniel Bristot de Oliveira
2021-04-14 17:14 ` Steven Rostedt
2021-04-15 13:43 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmz422gj.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=alexandre.chartre@oracle.com \
--cc=bristot@redhat.com \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kcarcia@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).