linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Sameer Pujar <spujar@nvidia.com>
Cc: <broonie@kernel.org>, <robh@kernel.org>,
	<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sharadg@nvidia.com>
Subject: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock
Date: 15 Feb 2021 08:25:35 +0900	[thread overview]
Message-ID: <87pn1244gg.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <93c9d656-8379-b463-e724-e48ce486c17d@nvidia.com>


Hi Sameer

> >          /*
> >           * Parse dai->sysclk come from "clocks = <&xxx>"
> >           * (if system has common clock)
> >           *  or "system-clock-frequency = <xxx>"
> >           *  or device's module clock.
> >           */
> 
> Yes, this can be rephrased now.

Thanks.
It is not a big-deal. no streass :)

> > And also, this patch has too many unneeded exchange,
> > thus it was difficult to read for me.
> > I think it can be simply like this ?
> > It is understandable what it want to do.
> 
> I think the patch does exactly the same thing as what you are
> suggesting below. Am I missing anything?

Yes, it is 100% same, but is simple patch.
I wanted to tell was it is easy to read/understand.
Your patch is already applied, so nothing we can do now ;)


Thank you for your help !!

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2021-02-14 23:26 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  6:43 [PATCH 0/3] Use clocks property in a device node Sameer Pujar
2021-02-10  6:43 ` [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock Sameer Pujar
2021-02-11 23:44   ` Kuninori Morimoto
2021-02-14 17:56     ` Sameer Pujar
2021-02-14 23:25       ` Kuninori Morimoto [this message]
2021-03-09 14:41   ` Michael Walle
2021-03-09 16:27     ` Sameer Pujar
2021-03-09 22:30       ` Michael Walle
2021-03-10 14:50         ` Sameer Pujar
2021-03-10 18:14           ` Michael Walle
2021-03-10 19:19             ` Sameer Pujar
2021-03-11 10:27           ` Michael Walle
2021-03-11 11:05             ` Sameer Pujar
2021-03-11 11:16               ` Michael Walle
2021-03-11 14:29                 ` Sameer Pujar
2021-03-11 15:43                   ` Michael Walle
2021-03-11 16:41                     ` Mark Brown
2021-03-11 16:15           ` Mark Brown
2021-03-11 22:11             ` Michael Walle
2021-03-12 11:35               ` Mark Brown
2021-03-12 12:01                 ` Michael Walle
2021-03-12 12:04                   ` Mark Brown
2021-03-12 12:30                     ` Michael Walle
2021-03-12 13:46                       ` Mark Brown
2021-03-15 12:05                         ` Michael Walle
2021-03-15 15:19                           ` Sameer Pujar
2021-03-15 15:33                             ` Michael Walle
2021-03-15 15:57                               ` Sameer Pujar
2021-03-15 15:39                             ` Mark Brown
2021-03-15 17:10                               ` Sameer Pujar
2021-03-15 17:13                                 ` Michael Walle
2021-03-11 16:00     ` Mark Brown
2021-03-11 21:34       ` Michael Walle
2021-02-10  6:43 ` [PATCH 2/3] Revert "ASoC: audio-graph-card: Add clocks property to endpoint node" Sameer Pujar
2021-02-11 13:00   ` Mark Brown
2021-02-10  6:43 ` [PATCH 3/3] arm64: tegra: Move clocks from RT5658 endpoint to device node Sameer Pujar
2021-02-11 15:38 ` [PATCH 0/3] Use clocks property in a " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn1244gg.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).