From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43936C5517A for ; Fri, 30 Oct 2020 23:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF52420709 for ; Fri, 30 Oct 2020 23:26:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="msLkbucZ"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ukQ/zD3p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725836AbgJ3X0K (ORCPT ); Fri, 30 Oct 2020 19:26:10 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:45598 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgJ3X0J (ORCPT ); Fri, 30 Oct 2020 19:26:09 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1604100366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BysKp1h3o8sBMwB2TAPG1V2I6LPAOQLiaGarMRHzzeQ=; b=msLkbucZt6Zr2TdRRib4dyDR0Hmqjd9PCcJZcYk2Y1Kr1ZHeC/yu/EIwOLyVB56b5rrdpp OdacYuXpMYpjP9QvQoxSkUy4+15KZ7mnez1Lt6Lta84CJdyeg+J/0zUeLEoJRKfOx53S17 dCpw0E5DGGOzwLCo8DNxzDNhnmNdmwNB6oX0FgcV8OsiJcfbj1iTy+odpmjKWyPbeoJbMv smX85NvwI3DS8olPym6LnXfgy7AKd0tQ6O98pWv/VYPzafvQyU//DV2jk5nWx0metTssku W29H4CAvM6xIk6KZE+gueTFcCV2msyvYHhyoy0vdg3fzuoyZKUA7dZJxYuDW2w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1604100366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BysKp1h3o8sBMwB2TAPG1V2I6LPAOQLiaGarMRHzzeQ=; b=ukQ/zD3pRqCynz3kjYH2vqm7QEULUzQexquSIj29pG2BIqkPvy5LfqQiDopGo7rLLtVPFL ef6qN/D2BkNlx2CQ== To: Linus Torvalds Cc: LKML , linux-arch , Peter Zijlstra , Paul McKenney , David Airlie , Daniel Vetter , Ard Biesheuvel , Herbert Xu , Christoph Hellwig , Sebastian Andrzej Siewior , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Andrew Morton , Linux-MM , the arch/x86 maintainers , Vineet Gupta , "open list\:SYNOPSYS ARC ARCHITECTURE" , Russell King , Arnd Bergmann , Linux ARM , Guo Ren , linux-csky@vger.kernel.org, Michal Simek , Thomas Bogendoerfer , linux-mips@vger.kernel.org, Nick Hu , Greentime Hu , Vincent Chen , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev , "David S. Miller" , linux-sparc , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Matthew Wilcox Subject: Re: [patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends In-Reply-To: References: <20201029221806.189523375@linutronix.de> <87pn50ob0s.fsf@nanos.tec.linutronix.de> <87blgknjcw.fsf@nanos.tec.linutronix.de> <87sg9vl59i.fsf@nanos.tec.linutronix.de> Date: Sat, 31 Oct 2020 00:26:05 +0100 Message-ID: <87pn4zl2ia.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30 2020 at 15:46, Linus Torvalds wrote: > On Fri, Oct 30, 2020 at 3:26 PM Thomas Gleixner wrote: > To me, your patch series has two big advantages: > > - more common code > > - kmap_local() becomes more of a no-op > > and the last thing we want is to expand on kmap. Happy to go with that. While trying to document the mess, I just stumbled over the abuse of kmap_atomic_prot() in drivers/gpu/drm/ttm/ttm_bo_util.c: dst = kmap_atomic_prot(d, prot); drivers/gpu/drm/ttm/ttm_bo_util.c: src = kmap_atomic_prot(s, prot); drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: kmap_atomic_prot(d->dst_pages[dst_page], drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: kmap_atomic_prot(d->src_pages[src_page], For !HIGHMEM kmap_atomic_prot() just ignores the 'prot' argument and returns the page address. Moar patches to be written ... Sigh! Thanks, tglx