From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: kernel test robot <lkp@intel.com>,
Kevin Yang <kevin_yang@realtek.com>,
"kbuild-all\@lists.01.org" <kbuild-all@lists.01.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'
Date: Fri, 28 Aug 2020 09:01:44 +0300 [thread overview]
Message-ID: <87pn7b9ulz.fsf@codeaurora.org> (raw)
In-Reply-To: <a3a708a0d8094b7895065d17e5396b82@realtek.com> (Tony Chuang's message of "Fri, 28 Aug 2020 02:25:46 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> + linux-wireless
>>
>> kernel test robot <lkp@intel.com> writes:
>>
>> > Hi Zong-Zhe,
>> >
>> > FYI, the error/warning still remains.
>> >
>> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> master
>> > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
>> > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract:
>> > export symbols about pci interface
>> > date: 10 weeks ago
>> > config: arc-randconfig-r026-20200725 (attached as .config)
>> > compiler: arc-elf-gcc (GCC) 9.3.0
>> > reproduce (this is a W=1 build):
>> > wget
>> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> > -O ~/bin/make.cross
>> > chmod +x ~/bin/make.cross
>> > git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36
>> > # save the attached .config to linux build tree
>> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
>> make.cross ARCH=arc
>> >
>> > If you fix the issue, kindly add following tag as appropriate
>> > Reported-by: kernel test robot <lkp@intel.com>
>> >
>> > All warnings (new ones prefixed by >>):
>> >
>> >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no
>> >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
>> > 1477 | int rtw_pci_probe(struct pci_dev *pdev,
>> > | ^~~~~~~~~~~~~
>> >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no
>> >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
>> > 1557 | void rtw_pci_remove(struct pci_dev *pdev)
>> > | ^~~~~~~~~~~~~~
>> >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no
>> >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
>> > 1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
>> > | ^~~~~~~~~~~~~~~~
>>
>> Tony, these are older warnings but please also check these.
>>
>
> I think this warning can be ignored, as the commit was going to export
> pci symbols for the follow-up patches to use, such as:
>
> f56f08636dda rtw88: extract: make 8723d an individual kernel module
> 416e87fcc780 rtw88: extract: make 8822b an individual kernel module
> ba0fbe236fb8 rtw88: extract: make 8822c an individual kernel module
>
> And these patches were submitted and applied together.
Good, thanks for checking.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-28 6:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 10:41 drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' kernel test robot
2020-08-27 10:46 ` Kalle Valo
2020-08-28 2:25 ` Tony Chuang
2020-08-28 6:01 ` Kalle Valo [this message]
2020-09-13 15:42 kernel test robot
2020-09-14 5:16 ` Tony Chuang
2020-09-14 7:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn7b9ulz.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=kevin_yang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).