linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Freddy Hsin <freddy.hsin@mediatek.com>,
	linux-mediatek@lists.infradead.or,
	linux-arm-kernel@lists.infradead.org,
	"Ahmed S. Darwish" <a.darwish@linutronix.de>,
	Paul Cercueil <paul@crapouillou.net>,
	"Ben Dooks \(Codethink\)" <ben.dooks@codethink.co.uk>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Saravana Kannan <saravanak@google.com>,
	linux-kernel@vger.kernel.org, chang-an.chen@mediatek.com,
	Baolin Wang <baolin.wang7@gmail.com>,
	wsd_upstream@mediatek.com, kuohong.wang@mediatek.com,
	stanley.chu@mediatek.com, Freddy Hsin <freddy.hsin@mediatek.com>
Subject: Re: [PATCH v1 1/2] kernel: time: export sched_clock_register function
Date: Wed, 29 Jul 2020 14:47:43 +0200	[thread overview]
Message-ID: <87pn8ea3o0.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1595931377-21627-2-git-send-email-freddy.hsin@mediatek.com>

Freddy,

Freddy Hsin <freddy.hsin@mediatek.com> writes:

please do not come up with random prefixes. Just look at the topmost two
commits on that file:

2c8bd58812ee ("time/sched_clock: Expire timer in hardirq context")
2707745533d6 ("time/sched_clock: Disable interrupts in sched_clock_register()")

Also the sentence after the colon starts with an uppercase letter.

Please change 'sched_clock_register function' to
'sched_clock_register()' which makes it clear that this is a function

> export sched_clock_register function, because the Mediatek timer
> loadable module depends on this function

Again sentences start with an uppercase letter. Also the reason for
exporting this is wrong. There is no mediatek timer module now.

The point of exporting this (if at all) is that it's required for any
ARM SoC timer driver to be modularized.
> @@ -239,6 +239,7 @@ static enum hrtimer_restart sched_clock_poll(struct hrtimer *hrt)
>  
>  	pr_debug("Registered %pS as sched_clock source\n", read);
>  }
> +EXPORT_SYMBOL(sched_clock_register);

EXPORT_SYMBOL_GPL() please.

Thanks,

        tglx

  reply	other threads:[~2020-07-29 12:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 10:16 [PATCH v1] Porting Mediatek timer driver to kernel module Freddy Hsin
2020-07-28 10:16 ` [PATCH v1 1/2] kernel: time: export sched_clock_register function Freddy Hsin
2020-07-29 12:47   ` Thomas Gleixner [this message]
2020-07-29 14:09   ` Daniel Lezcano
2020-07-28 10:16 ` [PATCH v1 2/2] timer: mt6873: porting Mediatek timer driver to loadable module Freddy Hsin
2020-07-29 13:02   ` Thomas Gleixner
2020-07-29 18:42     ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn8ea3o0.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=a.darwish@linutronix.de \
    --cc=baolin.wang7@gmail.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=chang-an.chen@mediatek.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=freddy.hsin@mediatek.com \
    --cc=kuohong.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.or \
    --cc=matthias.bgg@gmail.com \
    --cc=paul@crapouillou.net \
    --cc=saravanak@google.com \
    --cc=stanley.chu@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).