From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7545CC433DF for ; Sat, 30 May 2020 13:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E289207BC for ; Sat, 30 May 2020 13:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590844190; bh=WhjS/pGbgG5GCIYYKCDHTl07S+ISNbYJnu6798ZkKbQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=lcZ909c7twO4vLNywHLhLp2Z2hNg6o7a4shC84IH5zcLKpZWbJBzjte4FWzk9DVPM FE2dfnkg7ve3VfLSeFDLYZpcwXkTqUN9/F1JaRhUUrqL0mgj1UXDCN628H9trAzfAd npPEygfW7pNicbSzEVu7Yf2nNFf7qJrHcPLjl4ko= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728979AbgE3NJt (ORCPT ); Sat, 30 May 2020 09:09:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:51150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727947AbgE3NJs (ORCPT ); Sat, 30 May 2020 09:09:48 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09BF32074A; Sat, 30 May 2020 13:09:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590844188; bh=WhjS/pGbgG5GCIYYKCDHTl07S+ISNbYJnu6798ZkKbQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MtTtaJBWHxkIx2CwHiJSAzGdHdr3kEUozF6jtPJ9Vq0Yyda/UXCuxoD92gLJWSp2q zbp5jZD/kUw5hw3UJkDpb8aMGzdS+hcUbxSp8MelNm6mIhpMDUdewC3m+COQ6wzGI9 8ynpaf2PXwJtPeQNzJgQSCZDndzsY2ts2Glf6FH0= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jf1FC-00GXlU-8p; Sat, 30 May 2020 14:09:46 +0100 Date: Sat, 30 May 2020 14:09:45 +0100 Message-ID: <87pnalzi06.wl-maz@kernel.org> From: Marc Zyngier To: Jiaxun Yang Cc: kbuild test robot , Thomas Gleixner , Jason Cooper , Huacai Chen , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip: loongson-*: Fix COMPILE_TEST In-Reply-To: <20200530121113.1797678-3-jiaxun.yang@flygoat.com> References: <20200530121113.1797678-1-jiaxun.yang@flygoat.com> <20200530121113.1797678-3-jiaxun.yang@flygoat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jiaxun.yang@flygoat.com, lkp@intel.com, tglx@linutronix.de, jason@lakedaemon.net, chenhc@lemote.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 May 2020 13:11:13 +0100, Jiaxun Yang wrote: > > spurious_interrupt helper only exists on MIPS and x86, > so define a dummy function on other architectures to fix > COMPILE_TEST. > > Reported-by: kbuild test robot > Signed-off-by: Jiaxun Yang > --- > drivers/irqchip/irq-loongson-htpic.c | 4 ++++ > drivers/irqchip/irq-loongson-htvec.c | 4 ++++ > drivers/irqchip/irq-loongson-liointc.c | 4 ++++ > 3 files changed, 12 insertions(+) > > diff --git a/drivers/irqchip/irq-loongson-htpic.c b/drivers/irqchip/irq-loongson-htpic.c > index dd018c22ea83..7f38fdb2cb43 100644 > --- a/drivers/irqchip/irq-loongson-htpic.c > +++ b/drivers/irqchip/irq-loongson-htpic.c > @@ -26,6 +26,10 @@ struct loongson_htpic { > > static struct loongson_htpic *htpic; > > +#if !defined(CONFIG_MIPS) && !defined(CONFIG_X86) > +static inline void spurious_interrupt(void) { } > +#endif No, that's really horrible, and it doesn't scale. Dropping the COMPILE_TEST dependency is cleaner, and we should look into having a common framework across architectures to account for spurious interrupts. Not to mention that the HTPIC is not compiled with COMPILE_TEST anyway. > + > static void htpic_irq_dispatch(struct irq_desc *desc) > { > struct loongson_htpic *priv = irq_desc_get_handler_data(desc); > diff --git a/drivers/irqchip/irq-loongson-htvec.c b/drivers/irqchip/irq-loongson-htvec.c > index 1ece9337c78d..03c3973d7525 100644 > --- a/drivers/irqchip/irq-loongson-htvec.c > +++ b/drivers/irqchip/irq-loongson-htvec.c > @@ -33,6 +33,10 @@ struct htvec { > raw_spinlock_t htvec_lock; > }; > > +#if !defined(CONFIG_MIPS) && !defined(CONFIG_X86) > +static inline void spurious_interrupt(void) { } > +#endif I've already addressed this by dropping COMPILE_TEST. > + > static void htvec_irq_dispatch(struct irq_desc *desc) > { > int i; > diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c > index 63b61474a0cc..e31744e2d800 100644 > --- a/drivers/irqchip/irq-loongson-liointc.c > +++ b/drivers/irqchip/irq-loongson-liointc.c > @@ -46,6 +46,10 @@ struct liointc_priv { > bool has_lpc_irq_errata; > }; > > +#if !defined(CONFIG_MIPS) && !defined(CONFIG_X86) > +static inline void spurious_interrupt(void) { } > +#endif Neither is this one. M. -- Without deviation from the norm, progress is not possible.