From: Thomas Gleixner <tglx@linutronix.de>
To: afzal mohammed <afzal.mohd.ma@gmail.com>,
Thomas Bogendoerfer <tbogendoerfer@suse.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH 0/3] Remove setup_percpu_irq() & remove_percpu_irq
Date: Mon, 20 Apr 2020 19:31:16 +0200 [thread overview]
Message-ID: <87pnc2awt7.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200419144638.ysghqzklebkeer4z@afzalpc>
Afzal,
afzal mohammed <afzal.mohd.ma@gmail.com> writes:
> On Sat, Apr 11, 2020 at 09:34:07PM +0530, afzal mohammed wrote:
>
>> While doing the removal of setup_irq(), it was observed that
>> setup_percpu_irq() also can be removed similarly by replacing it w/
>> request_percpu_irq(), which does allocate memory. In the initial
>> setup_irq() removal cover letters [1], it was mentioned that
>> setup_percpu_irq() is untouched.
>>
>> After removing setup_irq(), it does not look good to let live
>> setup_percpu_irq(), especially since it being a low hanging fruit. Hence
>> replace setup_percpu_irq() by it's allocator equivalent.
>> request_percpu_irq() cannot be used since all the users need to pass
>> IRQF_TIMER flag, which it would not allow. Thus it's variant,
>> __request_percpu_irq() is used.
>>
>> In addition to removing setup_percpu_irq() definition,
>> remove_percpu_irq(), unused, is also removed.
>
> Do you feel that this series adds value ?, if not, i will abandon this
> series.
7 files changed, 10 insertions(+), 75 deletions(-)
is definitely worth it. There is no point in having two interfaces. I'll
have a look at the changes later today.
Thanks,
tglx
prev parent reply other threads:[~2020-04-20 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 16:04 [PATCH 0/3] Remove setup_percpu_irq() & remove_percpu_irq afzal mohammed
2020-04-11 16:04 ` [PATCH 1/3] MIPS: Replace setup_percpu_irq() by request_percpu_irq() variant afzal mohammed
2020-04-11 16:04 ` [PATCH 2/3] clocksource/drivers/mips-gic-timer: " afzal mohammed
2020-04-11 16:05 ` [PATCH 3/3] genirq: Remove setup_percpu_irq() and remove_percpu_irq() afzal mohammed
2020-04-19 14:46 ` [PATCH 0/3] Remove setup_percpu_irq() & remove_percpu_irq afzal mohammed
2020-04-20 17:31 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnc2awt7.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=afzal.mohd.ma@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).