From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B504C54F70 for ; Sun, 19 Apr 2020 23:38:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7B0420771 for ; Sun, 19 Apr 2020 23:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726012AbgDSXiL (ORCPT ); Sun, 19 Apr 2020 19:38:11 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:31111 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725834AbgDSXiK (ORCPT ); Sun, 19 Apr 2020 19:38:10 -0400 Date: 20 Apr 2020 08:38:09 +0900 X-IronPort-AV: E=Sophos;i="5.72,404,1580742000"; d="scan'208";a="45131356" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 20 Apr 2020 08:38:09 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 6E81B40062CC; Mon, 20 Apr 2020 08:38:09 +0900 (JST) Message-ID: <87pnc3t5b2.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Matthias Blankertz Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH 0/2] ASoC: rsnd: multi-SSI setup fixes In-Reply-To: <20200417153017.1744454-1-matthias.blankertz@cetitec.com> References: <20200417153017.1744454-1-matthias.blankertz@cetitec.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias > Fix rsnd_dai_call() operations being performed twice for the master SSI > in multi-SSI setups, and fix the rsnd_ssi_stop operation for multi-SSI > setups. > The only visible effect of these issues was some "status check failed" > spam when the rsnd_ssi_stop was called, but overall the code is cleaner > now, and some questionable writes to the SSICR register which did not > lead to any observable misbehaviour but were contrary to the datasheet > are fixed. > > Mark: > The first patch kind of reverts my "ASoC: rsnd: Fix parent SSI > start/stop in multi-SSI mode" from a few days ago and achieves the same > effect in a simpler fashion, if you would prefer a clean patch series > based on v5.6 drop me a note. Nice catch ! For all patches Acked-by: Kuninori Morimoto Thank you for your help !! Best regards --- Kuninori Morimoto