From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF41DC2BB1D for ; Fri, 17 Apr 2020 08:15:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BE5F2087E for ; Fri, 17 Apr 2020 08:15:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="CpqdRmRM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729648AbgDQIPV (ORCPT ); Fri, 17 Apr 2020 04:15:21 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:56204 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727871AbgDQIPV (ORCPT ); Fri, 17 Apr 2020 04:15:21 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587111320; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=u3586iFRwcYPsbJjaSDkiDP7IdnytFfQnBeWLZSw2rs=; b=CpqdRmRMl/tQcatguwEZBKjNF1x7B7o/jjX18N4qXMLpQi/xLx23iO2CQRZHUS7A0G3vFEIx sP/7jZYW/6x+ltf9OpKRVJ3hm+zMiAT7T9On8bWlhIz5748OJF5LYKkS+hRD8CKesfMgXMyl IgUjU8ozWKOlnQcPkFY5e3HjMsg= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e9962bc.7fe90db55848-smtp-out-n01; Fri, 17 Apr 2020 08:03:08 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 449FDC4478F; Fri, 17 Apr 2020 08:03:08 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 71443C433BA; Fri, 17 Apr 2020 08:03:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 71443C433BA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Sedat Dilek Cc: Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Rorvick Subject: Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer References: <20200417074558.12316-1-sedat.dilek@gmail.com> Date: Fri, 17 Apr 2020 11:03:03 +0300 In-Reply-To: <20200417074558.12316-1-sedat.dilek@gmail.com> (Sedat Dilek's message of "Fri, 17 Apr 2020 09:45:58 +0200") Message-ID: <87pnc6pmiw.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sedat Dilek writes: > From: Chris Rorvick > > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e > ("iwlwifi: dbg: move debug data to a struct") but does not implement the > check correctly. > > Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs") > Tweeted-by: @grsecurity > Message-Id: <20200402050219.4842-1-chris@rorvick.com> > Signed-off-by: Chris Rorvick > Signed-off-by: Sedat Dilek Thanks, looks good to me. I'll just remove the Message-Id tag, it's not really needed in this case. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches