From: Thomas Gleixner <tglx@linutronix.de>
To: "liuchao \(CR\)" <liuchao173@huawei.com>,
Neil Horman <nhorman@tuxdriver.com>
Cc: linfeilong <linfeilong@huawei.com>,
Hushiyuan <hushiyuan@huawei.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 答复: [RFC] irq: Skip printing irq when desc->action is null even if any_count is not zero
Date: Thu, 23 Jan 2020 13:34:33 +0100 [thread overview]
Message-ID: <87pnfatkpy.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <7966953BB2EC794AA37DF0A21FAD8A34021318DA@DGGEMA503-MBX.china.huawei.com>
Chao,
"liuchao (CR)" <liuchao173@huawei.com> writes:
> On Thu, Jan 23, 2020 at 03:29AM +0800, Neil Horman wrote:
>> > I'm not opposed to suppress the output, but I really want the opinion
>> > of the irqbalance maintainers on that.
>
> Irqbalance is an example. I mean, when this happens, users who cat /proc/interrupts
> may be confused about where the interrupt came from and what it was used for.
> People who use Linux may not understand the principle of this. They are not sure
> whether this is a problem of the system or not.
Well, this has been that way for 20+ years and so far nobody got
confused. If it's not documented then we should do so.
>> Actually, irqbalance ignores the trailing irq name (or it should at least), so you
>> should be able to drop that portion of /proc/irqbalance, though I cant speak for
>> any other users of it.
>
> If irq isn't removed from /proc/interrups, it will still be parsed in
> collect_full_irq_list and parse_proc_interrupts.
Sure, and why is that a problem? Again, this is really historic behaviour.
> irq_name is used in guess_arm_irq_hints.
That's a problem of guess_arm_irq_hints() then.
Again, I'm not against supressing such lines in general, but I want to
make sure that no tool depends on that information.
Thanks,
tglx
next prev parent reply other threads:[~2020-01-23 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:09 [RFC] irq: Skip printing irq when desc->action is null even if any_count is not zero l00520965
2020-01-22 12:42 ` Thomas Gleixner
2020-01-22 19:28 ` Neil Horman
2020-01-23 2:06 ` 答复: " liuchao (CR)
2020-01-23 12:34 ` Thomas Gleixner [this message]
2020-01-23 21:40 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnfatkpy.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=hushiyuan@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuchao173@huawei.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).