From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752128AbdKHSWf (ORCPT ); Wed, 8 Nov 2017 13:22:35 -0500 Received: from anholt.net ([50.246.234.109]:52584 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbdKHSWc (ORCPT ); Wed, 8 Nov 2017 13:22:32 -0500 From: Eric Anholt To: Florian Fainelli , linux-kernel@vger.kernel.org Cc: Florian Fainelli , Matt Mackall , Herbert Xu , Rob Herring , Mark Rutland , Ray Jui , Scott Branden , "maintainer\:BROADCOM BCM281XX\/BCM11XXX\/BCM216XX ARM ARCHITE..." , Stefan Wahren , PrasannaKumar Muralidharan , Russell King , Krzysztof Kozlowski , Harald Freudenberger , Sean Wang , Martin Kaiser , Steffen Trumtrar , "open list\:HARDWARE RANDOM NUMBER GENERATOR CORE" , "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list\:BROADCOM BCM2835 ARM ARCHITECTURE" , "moderated list\:BRO ADCOM BCM2835 ARM ARCHITECTURE" Subject: Re: [PATCH v2 02/12] hwrng: bcm2835-rng: Define a driver private context In-Reply-To: <20171108004449.32730-3-f.fainelli@gmail.com> References: <20171108004449.32730-1-f.fainelli@gmail.com> <20171108004449.32730-3-f.fainelli@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Wed, 08 Nov 2017 10:22:29 -0800 Message-ID: <87po8sy6je.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Florian Fainelli writes: > Instead of making hwrng::priv host the base register address, define a > driver private context, make it per platform device instance and pass it > down the different functions. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/bcm2835-rng.c | 55 ++++++++++++++++++++++-------------- > 1 file changed, 34 insertions(+), 21 deletions(-) > > diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c > index a818418a7e4c..0d72147ab45b 100644 > --- a/drivers/char/hw_random/bcm2835-rng.c > +++ b/drivers/char/hw_random/bcm2835-rng.c > -static struct hwrng bcm2835_rng_ops = { > - .name = "bcm2835", > - .read = bcm2835_rng_read, > -}; > - > /* map peripheral */ > - rng_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(rng_base)) { > + priv->base = devm_ioremap_resource(dev, r); > + if (IS_ERR(priv->base)) { > dev_err(dev, "failed to remap rng regs"); > - return PTR_ERR(rng_base); > + return PTR_ERR(priv->base); > } > - bcm2835_rng_ops.priv = (unsigned long)rng_base; > + > + priv->rng.name = "bcm2835-rng"; Looks like an unintentional change from the previous "bcm2835" here? Other than that, 1-2 are: Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAloDS2UACgkQtdYpNtH8 nuhw4w/+NIBhKh0AHhQFrwMLVIt3tqjEwuEgNq8KjCenaVzwt1V6YvDrwPH14jM5 0UMz1apFrej7TKC38IQ1EsAODiodJvYQC1p/Nl5gQS4/WfejUPyhYW6wvDfZTAOK l+9QA3IZQiHjo3Lwozp1bg35Bdt1RsaMV1fi9LElrcgF8DLzd4+G5m4sDllnZtTJ MaPVIBE+bGwS/XULzOROpcRGhGhtxad6pTENPxxJMgO9MrymNgXe5eZihH2d5OM+ YN5qQQNPIvmhYisgc0YoVvrqP1Od6JRIXssJNdUD10CyqDeV2A45QhvzLAB664HC w8Mm5TzJLgOptOeC3rDY38A+B8yT7B0SUIwv3ODITG0XFX43HVp9xDfxF8zX/+cI 9cuOsgAohjohPzgyqZbx5Hy+vqTOTCc9+Av0lfeWYoVoaGYXsVZXPgLbe+rctd39 gFjWMP6bz6Bb5dhFxOhr90GwwAQCIC2zfUGMAfHn3B0+Ae2odPSOiESjBac4Hyd3 X8EGg/ATsgxCzOzvBjmafYsgupJbtsJ4A6a9rbIKr2226vPRHWZJ8VZP3Qxvqa2a a2XRKGj5s5U+v5vum4/ly+Vr7DIlSYysUqfaGNpYBqUOFBzualghE7zQh7yiRrNn 5vHeiUGaudUatRK7TGoTWFx80647+YwoPcoJzCuV+3OtKaLtstY= =mpPQ -----END PGP SIGNATURE----- --=-=-=--