From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1161509AbdAEMyQ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 07:54:16 -0500
Received: from mail-wj0-f196.google.com ([209.85.210.196]:36801 "EHLO
        mail-wj0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1161482AbdAEMxz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 07:53:55 -0500
From: Nicolai Stange <nicstange@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Nicolai Stange <nicstange@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, "x86\@kernel.org" <x86@kernel.org>,
        "linux-efi\@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mika =?utf-8?Q?Penttil=C3=A4?= <mika.penttila@nextfour.com>,
        Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH v2 1/2] x86/efi: don't allocate memmap through memblock after mm_init()
References: <20161222102340.2689-1-nicstange@gmail.com>
        <20161223145206.GC16838@codeblueprint.co.uk>
        <878tr6jqoa.fsf@gmail.com> <20170105074221.GA1777@gmail.com>
        <CAKv+Gu9AabgVMQ+uZkmiJZt9shBB=j4XUccRoRJcv5+T8X7eAw@mail.gmail.com>
        <87inpt6ce7.fsf@gmail.com>
        <CAKv+Gu-KEJ3t5kqedbcmkagyxHusuvj2whc5zLY521tRtenUBg@mail.gmail.com>
Date: Thu, 05 Jan 2017 13:53:50 +0100
In-Reply-To: <CAKv+Gu-KEJ3t5kqedbcmkagyxHusuvj2whc5zLY521tRtenUBg@mail.gmail.com>
        (Ard Biesheuvel's message of "Thu, 5 Jan 2017 11:34:06 +0000")
Message-ID: <87pok1hdlt.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ard Biesheuvel <ard.biesheuvel@linaro.org> writes:
> On 5 January 2017 at 10:15, Nicolai Stange <nicstange@gmail.com> wrote:
>> So, are you Ok with only taking the other review comment, namely
>>
>>   "modify efi_fake_memmap() to use your new efi_memmap_alloc() function
>>    for consistency"
>>
>> into account for a v3?
>>
>
> Yes, that should be sufficient for a fix that can be backported.
> Anything else can wait for now


Ard, thanks for your help!

v3 is here:

  http://lkml.kernel.org/r/20170105125130.2815-1-nicstange@gmail.com


Nicolai