From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426331AbcFHOq7 (ORCPT ); Wed, 8 Jun 2016 10:46:59 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:38056 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424457AbcFHOq5 convert rfc822-to-8bit (ORCPT ); Wed, 8 Jun 2016 10:46:57 -0400 X-IronPort-AV: E=Sophos;i="5.26,439,1459839600"; d="scan'208";a="294342717" X-IronPort-AV: E=McAfee;i="5700,7163,8190"; a="1212049530" From: "Valo, Kalle" To: Prasun Maiti CC: Linux Kernel , "ath6kl@lists.infradead.org" , Linux Next , "Linux Wireless" Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Thread-Topic: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Thread-Index: AQHRwZSVI/J+9EukKEagXKh3JuDmhw== Date: Wed, 8 Jun 2016 14:46:47 +0000 Message-ID: <87porrkaax.fsf@kamboji.qca.qualcomm.com> References: <1465388474-20503-1-git-send-email-prasunmaiti87@gmail.com> <87wplzkbd9.fsf@kamboji.qca.qualcomm.com> In-Reply-To: (Prasun Maiti's message of "Wed, 8 Jun 2016 20:05:15 +0530") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="us-ascii" Content-ID: <89CFE10F2E35A04BBE123A2233089962@qualcomm.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prasun Maiti writes: > No. I did not any test for that case. > This driver create a new wiphy for use with cfg80211 through > "wiphy_new_nm" api, but in this api, I found that more warnings for > inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && > !ops->get_antenna);" > So, warning comes during creation of a new wiphy. That's why It is needed. I'm confused. Are you really saying that you added a new firmware command (WMI_SET_ANTENNA_CMDID) to ath6kl but you didn't test it in any way? How do you know that it works then? -- Kalle Valo