From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358AbcFFV3b (ORCPT ); Mon, 6 Jun 2016 17:29:31 -0400 Received: from anholt.net ([50.246.234.109]:48117 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbcFFV3a (ORCPT ); Mon, 6 Jun 2016 17:29:30 -0400 From: Eric Anholt To: Colin King , David Airlie , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: clean up error exit path on failed dpi_connector allocation In-Reply-To: <1464860309-8523-1-git-send-email-colin.king@canonical.com> References: <1464860309-8523-1-git-send-email-colin.king@canonical.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 06 Jun 2016 14:29:26 -0700 Message-ID: <87poruhuq1.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Colin King writes: > From: Colin Ian King > > There is redundant code in the clean up exit path when dpi_connector > fails to be allocated. The current code checks if connector is NULL > before destroying it, in fact, connector is NULL at this point so > the check is redundant and can be removed. The final clean up is > that we can remove the goto fail with a simple return and the unused > variable ret. > > Signed-off-by: Colin Ian King Reviewed and pulled to drm-vc4-next. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXVes2AAoJELXWKTbR/J7oLcQQALdiKDb1oKCQZ1LO/b8ZUgjK 5kOrod0/2icWNvMyW9gR8lEwfqwuqjCi+6FtY37fR6kFtbcXB9JzKU8d/wiJ3DFE x7nuUtvf76b92ABcOT4PNWC7UdOMFWL6TOgPfJJj63nIiwHXHP07kgSzJqZu5DJq YsLshKWy6Bzm2l6PUVz3Z1920wROKDyFOuttN6+papIc3svYZnC+fk8Az7dSyYdE j8xon3TI7EJ8KjxlziDyZ1ePVkeKJOR7KEedWqFku3t5VV4c9SPDBKpN0FRcufxf BVJLETEkYqnA7M1IWbXKA/ZfDvMqxdnk4mcbHrNqEGPy3yJ4DXriasTTtQm7vrzg Z+Dvw4H/GDrY4s1pRCdbuB14bep1sUEZufRNCIVJSVVYPd+PCgRLmAQXttwU2Apr QruiMtM6E2jO0ngkvol8SBMbcXzIReLT3XmNuZ6JLmFZeikHzWoVG6ftGQ8N7wM2 0N4rX1PDXT6xVvSbt9UdpeqW/HI8DWFcC4deq6sCuKFGTYwgLZknuxloboi5L8ao TD97I/GuJDTuV9uECNdzh1aOkSo0wxgfaIkUEtACaQL94rfkUdN7QelQstLM8g9J J+9+d7F++B/Kgm3zeckfefj9McinCVt+e9fCYZ6YDIp8TsfnS0T+OLbAk9iIZ6oV qHF8s6Uy6vGXGNJAs5LS =fkA6 -----END PGP SIGNATURE----- --=-=-=--