linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	David Airlie <airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>,
	<linux-renesas-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <koji.matsuoka.xm@renesas.com>,
	<yoshihiro.shimoda.uh@renesas.com>, <naoya.shiiba.nx@renesas.com>,
	<ryo.kodama.vz@renesas.com>, <hiroyuki.yokoyama.vx@renesas.com>,
	<yoshifumi.hosoya.wj@renesas.com>,
	<takeshi.kihara.df@renesas.com>,
	<toshiaki.komatsu.ud@renesas.com>,
	<harunobu.kurokawa.dn@renesas.com>,
	<ryusuke.sakato.bx@renesas.com>, <tomoharu.fukawa.eb@renesas.com>,
	<kouei.abe.cp@renesas.com>, <khiem.nguyen.xt@rvc.renesas.com>,
	<hien.dang.eb@rvc.renesas.com>
Subject: [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message
Date: Tue, 24 May 2016 14:24:09 +0900	[thread overview]
Message-ID: <87posc9gg6.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <redmine.journal-710718.20160523104049.392ea8e63d81580c@dm.renesas.com>


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

EPROBE_DEFER is not error, thus, error message on kernel log on this
case is confusable for user. Prints it only error cases.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 26fd3ba..1db080c 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -354,14 +354,16 @@ static int rcar_du_probe(struct platform_device *pdev)
 	 */
 	ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1);
 	if (ret < 0) {
-		dev_err(&pdev->dev, "failed to initialize vblank\n");
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "failed to initialize vblank\n");
 		goto error;
 	}
 
 	/* DRM/KMS objects */
 	ret = rcar_du_modeset_init(rcdu);
 	if (ret < 0) {
-		dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret);
 		goto error;
 	}
 
-- 
1.9.1

       reply	other threads:[~2016-05-24  5:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-77851.20151006064038@dm.renesas.com>
     [not found] ` <redmine.journal-710718.20160523104049.392ea8e63d81580c@dm.renesas.com>
2016-05-24  5:24   ` Kuninori Morimoto [this message]
2016-05-24 13:32     ` [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message Laurent Pinchart
2016-05-25  0:13       ` Kuninori Morimoto
2016-05-25  0:38   ` [PATCH 0/2 v2] " Kuninori Morimoto
2016-05-25  0:40     ` [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank_init() Kuninori Morimoto
2016-05-25  0:41     ` [PATCH 2/2 v2] drm: rcar-du: error message is not needed for EPROBE_DEFER Kuninori Morimoto
2016-06-09  3:03     ` [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message Kuninori Morimoto
2016-06-10 21:07     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87posc9gg6.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harunobu.kurokawa.dn@renesas.com \
    --cc=hien.dang.eb@rvc.renesas.com \
    --cc=hiroyuki.yokoyama.vx@renesas.com \
    --cc=khiem.nguyen.xt@rvc.renesas.com \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=kouei.abe.cp@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=naoya.shiiba.nx@renesas.com \
    --cc=ryo.kodama.vz@renesas.com \
    --cc=ryusuke.sakato.bx@renesas.com \
    --cc=takeshi.kihara.df@renesas.com \
    --cc=tomoharu.fukawa.eb@renesas.com \
    --cc=toshiaki.komatsu.ud@renesas.com \
    --cc=yoshifumi.hosoya.wj@renesas.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).