From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net, agk@redhat.com,
snitzer@redhat.com, axboe@fb.com, dm-devel@redhat.com,
akpm@linux-foundation.org, david.s.gordon@intel.com,
thomas.lendacky@amd.com, yamada.masahiro@socionext.com,
smueller@chronox.de, tadeusz.struk@intel.com,
standby24x7@gmail.com, shli@kernel.org, broonie@kernel.org,
linus.walleij@linaro.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/4] scatterlist: Introduce some helper functions
Date: Thu, 03 Mar 2016 20:15:42 +0100 [thread overview]
Message-ID: <87povbpe3l.fsf@belgarion.home> (raw)
In-Reply-To: <3bff3e286d3ee01ebb7e26d7233075054c42a7a9.1456981314.git.baolin.wang@linaro.org> (Baolin Wang's message of "Thu, 3 Mar 2016 13:19:36 +0800")
Baolin Wang <baolin.wang@linaro.org> writes:
> @@ -212,6 +212,37 @@ static inline void sg_unmark_end(struct scatterlist *sg)
> }
>
> /**
> + * sg_is_contiguous - Check if the scatterlists are contiguous
> + * @sga: SG entry
> + * @sgb: SG entry
> + *
> + * Description:
> + * If the sga scatterlist is contiguous with the sgb scatterlist,
> + * that means they can be merged together.
> + *
> + **/
> +static inline bool sg_is_contiguous(struct scatterlist *sga,
> + struct scatterlist *sgb)
> +{
> + return ((sga->page_link & ~0x3UL) + sga->offset + sga->length ==
> + (sgb->page_link & ~0x3UL));
> +}
I don't understand that one.
sga->page_link is a pointer to a "struct page *". How can it be added to an
offset within a page ???
> @@ -370,6 +370,65 @@ int sg_alloc_table(struct sg_table *table, unsigned int
> nents, gfp_t gfp_mask)
...
> /**
> + * sg_add_sg_to_table - Add one scatterlist into sg table
> + * @sgt: The sg table header to use
> + * @src: The sg need to be added into sg table
> + *
> + * Description:
> + * The 'nents' member indicates how many scatterlists added in the sg table.
> + * Copy the @src@ scatterlist into sg table and increase 'nents' member.
> + *
> + **/
> +int sg_add_sg_to_table(struct sg_table *sgt, struct scatterlist *src)
> +{
> + unsigned int i = 0, orig_nents = sgt->orig_nents;
> + struct scatterlist *sgl = sgt->sgl;
> + struct scatterlist *sg;
> +
> + /* Check if there are enough space for the new sg to be added */
> + if (sgt->nents >= sgt->orig_nents)
> + return -EINVAL;
I must admit I don't understand that one either : how do comparing the number of
"mapped" entries against the number of "allocated" entries determines if there
is enough room ?
> +/**
> + * sg_alloc_empty_table - Allocate one empty sg table
> + * @sgt: The sg table header to use
> + * @nents: Number of entries in sg list
> + * @gfp_mask: GFP allocation mask
> + *
> + * Description:
> + * Allocate and initialize an sg table. The 'nents' member of sg_table
> + * indicates how many scatterlists added in the sg table. It should set
> + * 0 which means there are no scatterlists added in this sg table now.
> + *
> + **/
> +int sg_alloc_empty_table(struct sg_table *sgt, unsigned int nents,
> + gfp_t gfp_mask)
As for this one, there has to be a purpose for it I fail to see. From far away
it looks exactly like sg_alloc_table(), excepting it "works around" the nents >
0 protection of __sg_alloc_table().
What is exactly the need for this one, and if it's usefull why not simply
changing the __sg_alloc_table() "nents > 0" test and see what the outcome of the
review will be ?
Cheers.
--
Robert
next prev parent reply other threads:[~2016-03-03 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 5:19 [PATCH 0/4] Introduce bulk mode for crypto engine framework Baolin Wang
2016-03-03 5:19 ` [PATCH 1/4] scatterlist: Introduce some helper functions Baolin Wang
2016-03-03 19:15 ` Robert Jarzmik [this message]
2016-03-04 6:29 ` Baolin Wang
2016-03-04 6:53 ` Baolin Wang
2016-03-10 9:42 ` Robert Jarzmik
2016-03-10 12:58 ` Baolin Wang
2016-03-03 5:19 ` [PATCH 2/4] crypto: Introduce some helper functions to help to merge requests Baolin Wang
2016-03-03 5:19 ` [PATCH 3/4] crypto: Introduce the bulk mode for crypto engine framework Baolin Wang
2016-03-03 5:19 ` [PATCH 4/4] md: dm-crypt: Initialize the sector number for one request Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87povbpe3l.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=david.s.gordon@intel.com \
--cc=dm-devel@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linus.walleij@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
--cc=smueller@chronox.de \
--cc=snitzer@redhat.com \
--cc=standby24x7@gmail.com \
--cc=tadeusz.struk@intel.com \
--cc=thomas.lendacky@amd.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).