From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B9FC433F5 for ; Sun, 9 Oct 2022 02:32:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbiJICcm (ORCPT ); Sat, 8 Oct 2022 22:32:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229787AbiJICci (ORCPT ); Sat, 8 Oct 2022 22:32:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FCC72EF2A; Sat, 8 Oct 2022 19:32:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 46F31B80B8E; Sun, 9 Oct 2022 02:32:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEF9DC433C1; Sun, 9 Oct 2022 02:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665282754; bh=PsyHGvzuTaze5Ppuq373alLCShMikDx1lFtmDWHBuR4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nBEw6E4Ebe7MkBaHFPDkKiy63w2vWvWDhrKir7AKlKygFp7C1rJem8W3OMLZv6OQV 6hydFNB9hcisgSjn7du0bFZBjuHMoDMwXWe59/371KloUgTOSf+WqoDtj6TBVpG1yy EGER0zStWtQKQ3ep/YyAJwNEXfsZFZCoHZLLdMFWuplBeD6FjcpljLYDixiQz3gfIg Kb1m357YrDSw9t8SQrJ4vrK2NUk1+jqtFqidkpA6DKNA+aF81wdivhk0ET2HyY8BuN eEdmZlqFT+1QMAY8R/H95VDveFEMg7VFLzcoTfF8UEUey7C/pRN+sXZadH9ELTkrqO 4M5DglohVPSlQ== Received: from [156.39.10.100] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ohM7E-00FLF6-6k; Sun, 09 Oct 2022 03:32:32 +0100 Date: Sun, 09 Oct 2022 03:31:33 +0100 Message-ID: <87r0zhhgmy.wl-maz@kernel.org> From: Marc Zyngier To: Jianmin Lv Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Jiaxun Yang , Huacai Chen , Bjorn Helgaas , Len Brown , rafael@kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH V2 1/2] irqchip/loongson-pch-pic: Support to set irq type for ACPI path In-Reply-To: <7d3894f9-9708-0b4f-b485-f167408feede@loongson.cn> References: <20221008025150.10734-1-lvjianmin@loongson.cn> <20221008025150.10734-2-lvjianmin@loongson.cn> <87v8othkgz.wl-maz@kernel.org> <7d3894f9-9708-0b4f-b485-f167408feede@loongson.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 156.39.10.100 X-SA-Exim-Rcpt-To: lvjianmin@loongson.cn, tglx@linutronix.de, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, jiaxun.yang@flygoat.com, chenhuacai@loongson.cn, bhelgaas@google.com, lenb@kernel.org, rafael@kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 09 Oct 2022 03:26:21 +0100, Jianmin Lv wrote: > > Ok, thanks, I'll separate this patch, so we have to make the patch > fixing PCI INTx handling to be after the patch supporting for the LPIC > model to avoid kernel hang, yes? Pick whatever order fits your system, really. But don't mix generic ACPI changes and irqchip code in the same patch, that's just wrong. Thanks, M. -- Without deviation from the norm, progress is not possible.