From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B835CECAAD2 for ; Sun, 28 Aug 2022 07:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232901AbiH1Htl (ORCPT ); Sun, 28 Aug 2022 03:49:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231919AbiH1Htj (ORCPT ); Sun, 28 Aug 2022 03:49:39 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 407BC3AB38 for ; Sun, 28 Aug 2022 00:49:38 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 705F733686; Sun, 28 Aug 2022 07:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1661672976; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJVPwI1SQW1ugxTkbUHGFWs/aY/52eay/l04VrZPyTM=; b=bq/8iHPQw5+JhEo7UduZr1wtM5gSgjb/LbHPkT2dJ2movE/eE3Gie3I2eUfk8xSpbxs13p p1bIoxlginjUrpBeJDgadw3xDTpJwnCXC++ftSgWhV8XoMcKm+pw72Co1zxKiqOCNK4fJU u9UoPloFHaLd4TXnNR4upLH9w9GC1dk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1661672976; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJVPwI1SQW1ugxTkbUHGFWs/aY/52eay/l04VrZPyTM=; b=GigM/Qmv3yE+y+XWxx0802Ez5+5qkX8U3uTdT5tY+myptJVTeFZEVnraRc0Rk/Z55tm5eq xhskzc0TT2IeULCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4936213A65; Sun, 28 Aug 2022 07:49:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y94pERAeC2MGcgAAMHmgww (envelope-from ); Sun, 28 Aug 2022 07:49:36 +0000 Date: Sun, 28 Aug 2022 09:49:35 +0200 Message-ID: <87r110iz8w.wl-tiwai@suse.de> From: Takashi Iwai To: Sean Anderson Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Linux Kernel Mailing List Subject: Re: retire_capture_urb: Corrected urb data len In-Reply-To: <9d41eda1-1172-ea60-dd87-b3e38a529170@seco.com> References: <68a97d61-21bf-b45e-f6ed-c0906dd4b197@seco.com> <87ilmfj72j.wl-tiwai@suse.de> <9d41eda1-1172-ea60-dd87-b3e38a529170@seco.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Aug 2022 20:57:53 +0200, Sean Anderson wrote: > > On 8/26/22 12:36 PM, Takashi Iwai wrote: > > On Fri, 26 Aug 2022 18:22:24 +0200, > > Sean Anderson wrote: > >> > >> Hi all, > >> > >> I have a "FiiO DigiHug USB Audio" sound card (1852:7022) [3]. I have had > >> no problems with the audio, but I did notice a large number of message > >> like > >> > >> retire_capture_urb: 4992 callbacks suppressed > >> > >> in my dmesg [1]. This is caused by the "Corrected urb data len." > >> warning. > > > > What exact values are shown there? > > Unfortunately, as detailed below, I was unable to turn off ratelimiting. > > > The problem is that your hardware > > (likely a buggy firmware) returns the unaligned size of bytes as the > > data. Maybe it's worth to replace dev_warn_ratelimited() there with > > dev_warn() and take all warnings once. Then we can see what kind of > > values are delivered from the hardware. > > I'll have an attempt at that next week > > >> The patch adding this warning [2] makes it seem like > >> this warning should be an uncommon occurance. However, based on the > >> number of suppressed callbacks, this seems to be happening at a rate of > >> around 500 Hz. > >> > >> Is this buggy hardware? Or is this a bug in the driver? Does there need > >> to be a quirk? Or perhaps the warning above should be a debug instead? > > > > There is no quirk for that. As long as the device works with that > > workaround (except for messages), we can simply add a quirk to not > > warn but always apply the workaround silently for such devices. > > OK. I wasn't sure what the correct resolution would be. Actually I was wrong: the existing quirk QUIRK_FLAG_ALIGN_TRANSFER should cover that. Could you try to pass quirk_flags=0x04 for the corresponding card slot (the option takes an array) to snd-usb-audio module? Alternatively, try to pass quirk_alias=18557022:0e510408 to snd-usb-audio? thanks, Takashi