From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F29DC2BB41 for ; Wed, 17 Aug 2022 12:19:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236698AbiHQMTS (ORCPT ); Wed, 17 Aug 2022 08:19:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238988AbiHQMTP (ORCPT ); Wed, 17 Aug 2022 08:19:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E920369F7D; Wed, 17 Aug 2022 05:19:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F67260B82; Wed, 17 Aug 2022 12:19:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFD7FC433D6; Wed, 17 Aug 2022 12:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660738752; bh=BBTXORGlFEwLgbRuxkkzNMEk2vrtwEdIFHOCs3ywN/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pR/Fqpc4qFciyFif+Rz7Y2QU1wPblmLNOUD0NN87Gmz8UpPn1g3rm0bAXA5dTfs33 AqfH02QQfopKJx5JzziZnxrQDP4xohcoSzhk5Hp8ItmrhQjEXbPV5gX2RDTRJuH1AY b8Gu8UAdLP4Gj2DHWLrRICkNKd3q/C76ls5hom4lTX20h7Pt9rSFEG8gtl/3Qrb6kZ xFcHDLZK/FNXRKWKYuBfTMETBatSkKQhZCjqR4g0xTQEoDWP2kRbg+uJ38bYhRWLzA T/V2c978rL/8qyhb9ZGzLsBMGgNmzZhjUY9CFNjE3j2TD48GpL6XIbwc/TYAHYJcTB 5xvlEqfxQY6PA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oOI0s-003j3K-Hy; Wed, 17 Aug 2022 13:19:10 +0100 Date: Wed, 17 Aug 2022 13:19:10 +0100 Message-ID: <87r11fvz9d.wl-maz@kernel.org> From: Marc Zyngier To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, catalin.marinas@arm.com, jean-philippe@linaro.org, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, tglx@linutronix.de, alex.williamson@redhat.com, cohuck@redhat.com, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h In-Reply-To: <9cd99738f52094e6bed44bfee03fa4f288d20695.1660668998.git.robin.murphy@arm.com> References: <9cd99738f52094e6bed44bfee03fa4f288d20695.1660668998.git.robin.murphy@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, catalin.marinas@arm.com, jean-philippe@linaro.org, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, tglx@linutronix.de, alex.williamson@redhat.com, cohuck@redhat.com, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Aug 2022 18:28:04 +0100, Robin Murphy wrote: > > The iommu-dma layer is now mostly encapsulated by iommu_dma_ops, with > only a couple more public interfaces left pertaining to MSI integration. > Since these depend on the main IOMMU API header anyway, move their > declarations there, taking the opportunity to update the half-baked > comments to proper kerneldoc along the way. > > Signed-off-by: Robin Murphy > --- > > Note that iommu_setup_dma_ops() should also become internal in a future > phase of the great IOMMU API upheaval - for now as the last bit of true > arch code glue I consider it more "necessarily exposed" than "public". > > arch/arm64/mm/dma-mapping.c | 2 +- > drivers/iommu/dma-iommu.c | 15 ++++++++++-- > drivers/irqchip/irq-gic-v2m.c | 2 +- > drivers/irqchip/irq-gic-v3-its.c | 2 +- > drivers/irqchip/irq-gic-v3-mbi.c | 2 +- > drivers/irqchip/irq-ls-scfg-msi.c | 2 +- > drivers/vfio/vfio_iommu_type1.c | 1 - > include/linux/dma-iommu.h | 40 ------------------------------- > include/linux/iommu.h | 36 ++++++++++++++++++++++++++++ > 9 files changed, 54 insertions(+), 48 deletions(-) For the irqchip side: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.