From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8830AC433EF for ; Tue, 29 Mar 2022 07:07:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233296AbiC2HJh (ORCPT ); Tue, 29 Mar 2022 03:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232859AbiC2HJd (ORCPT ); Tue, 29 Mar 2022 03:09:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E953323D5AF; Tue, 29 Mar 2022 00:07:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AAEB76152F; Tue, 29 Mar 2022 07:07:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CC48C2BBE4; Tue, 29 Mar 2022 07:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648537640; bh=nQUP/FbGXeuylpTH5/b3zyp7BFtDjtEua/L88aOE6cc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LOsDzegZzfHWobPhUSjo+fS0pkmNbYdNkDxNG5AEmOj/qltw5OBAdpLcwyr4crcqx L5NEsAWfpVcS1Zi0Ioy8GKmC8SHSTJVdarhmySpt9QgA87E4X1VnBBGVPIde/MPmID Zrii/Ov86Mcz2jdmJ3lT/ZSrn4spzwjSNgv19jjLFncof4C6ddR3Y6rSrcBuC53M/c uuX0uClv2TgkEAgb66bNcVVpQNkzFsYAfMlWdzTi4jEIMWvVYYHTLjlTK645Ln6ZdE ZeayuFwvK+a1Wpg7w73Ple9E994Yq5CbHmgQUL3puRjtNWiLzkOPPW8URlBs2uzmM8 fh6AhpaJemo9g== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nZ5wj-00HaMS-BO; Tue, 29 Mar 2022 08:07:17 +0100 Date: Tue, 29 Mar 2022 08:07:12 +0100 Message-ID: <87r16li6e7.wl-maz@kernel.org> From: Marc Zyngier To: yuzhe Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, liqiong@nfschina.com, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings In-Reply-To: <0f4cf955-ca2b-626f-867e-5a0ecfe68ca1@nfschina.com> References: <20220328103836.2829-1-yuzhe@nfschina.com> <87h77ifbbd.wl-maz@kernel.org> <0f4cf955-ca2b-626f-867e-5a0ecfe68ca1@nfschina.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: yuzhe@nfschina.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, liqiong@nfschina.com, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Mar 2022 07:14:16 +0100, yuzhe wrote: > > >> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq, > >> static int vgic_debug_show(struct seq_file *s, void *v) > >> { > >> - struct kvm *kvm = (struct kvm *)s->private; > >> + struct kvm *kvm = s->private; > >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v; > > How about you fully get rid of the unnecessary casts then? > > > > M. > > I don't know what you exactly mean. I follow the > kernel-janitors/TODO List to get rid of the unnecessary casts. And > I checked all the code in the arch directory and found these issues. Let me quote the lines again: > >> static int vgic_debug_show(struct seq_file *s, void *v) [...] > >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v; Do you see what I mean? M. -- Without deviation from the norm, progress is not possible.