From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 989C5C433B4 for ; Mon, 17 May 2021 05:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BAFE61206 for ; Mon, 17 May 2021 05:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233616AbhEQF7i (ORCPT ); Mon, 17 May 2021 01:59:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233019AbhEQF72 (ORCPT ); Mon, 17 May 2021 01:59:28 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2904C061573; Sun, 16 May 2021 22:57:57 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Fk7hc0mXSz9sV5; Mon, 17 May 2021 15:57:51 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1621231073; bh=23IxQnM2rd7cPGZcKn0tcckrg/JRDK/oIHWajK2PHyI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GDCBgC/Dg+s41CCHmGYd+4n2TML+KIXYY2kyYsBVxK1131LyXmhlErOx6xeYg2C8y Ul1yT3LuFEmFNLtn1XO0PfDM47geet4+mfJLLv1Aidqmhrs3VNoiXjUKwkYHZNYfWR qb90ygKHiqs0wkwSXFPjOvC+fi0e8BCCOCv5j7y9goAhbXm1mYV7I8BDUhk6FnP1Fs h9ujBu1ezavkfdOPYnEIWWOO8t8fF1PWNKwSxfhllkJvH9F6xpGm+YrthwgCBZ+giA nbhgIyXtgOy4Hof8EBfqaivhYgNPImd8SBiMkU0YD8MwGISrKJLtAdYJy/Hno9eO9g Q+NvyZeQuuCNg== From: Michael Ellerman To: Wan Jiabing , Benjamin Herrenschmidt , Paul Mackerras , Shuah Khan , Jordan Niethe , Michael Neuling , Wan Jiabing , linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kael_w@yeah.net Subject: Re: [PATCH] [v2] selftests: powerpc: Remove unneeded variables In-Reply-To: <20210412125746.2766-1-wanjiabing@vivo.com> References: <20210412125746.2766-1-wanjiabing@vivo.com> Date: Mon, 17 May 2021 15:57:48 +1000 Message-ID: <87r1i5kilf.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wan Jiabing writes: > Fix coccicheck warning: > > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:539:5-7: > Unneeded variable: "rc". Return "0" on line 562 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:567:5-7: > Unneeded variable: "rc". Return "0" on line 580 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:585:5-7: > Unneeded variable: "rc". Return "0" on line 594 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:600:5-7: > Unneeded variable: "rc". Return "0" on line 611 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:416:5-7: > Unneeded variable: "rc". Return "0" on line 470 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:475:5-7: > Unneeded variable: "rc". Return "0" on line 485 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:490:5-7: > Unneeded variable: "rc". Return "0" on line 506 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:511:5-7: > Unneeded variable: "rc". Return "0" on line 534 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:331:5-7: > Unneeded variable: "rc". Return "0" on line 344 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:349:5-7: > Unneeded variable: "rc". Return "0" on line 360 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:365:5-7: > Unneeded variable: "rc". Return "0" on line 392 > ./tools/testing/selftests/powerpc/alignment/alignment_handler.c:397:5-7: > Unneeded variable: "rc". Return "0" on line 411 > > Signed-off-by: Wan Jiabing > --- > Changelog: > v2: > - Modify the subject line. > --- > .../powerpc/alignment/alignment_handler.c | 48 +++++-------------- > 1 file changed, 12 insertions(+), 36 deletions(-) This breaks the build. Please don't send selftest patches you haven't even build tested. cheers powerpc64le-linux-gnu-gcc -std=gnu99 -O2 -Wall -Werror -DGIT_VERSION='"v5.13-rc2-30-g0510571fcf78"' -I/linux/tools/testing/selftests/powerpc/include alignment_handler.c ../harness.c ../utils.c -o /output/kselftest/powerpc/alignment/alignment_handler alignment_handler.c: In function 'test_alignment_handler_vsx_206': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:106:33: note: in expansion of macro 'TEST' 106 | #define LOAD_VSX_XFORM_TEST(op) TEST(op, op, stxvd2x, XFORM, 32, 32) | ^~~~ alignment_handler.c:326:2: note: in expansion of macro 'LOAD_VSX_XFORM_TEST' 326 | LOAD_VSX_XFORM_TEST(lxvd2x); | ^~~~~~~~~~~~~~~~~~~ alignment_handler.c:93:2: note: each undeclared identifier is reported only once for each function it appears in 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:106:33: note: in expansion of macro 'TEST' 106 | #define LOAD_VSX_XFORM_TEST(op) TEST(op, op, stxvd2x, XFORM, 32, 32) | ^~~~ alignment_handler.c:326:2: note: in expansion of macro 'LOAD_VSX_XFORM_TEST' 326 | LOAD_VSX_XFORM_TEST(lxvd2x); | ^~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_vsx_207': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:106:33: note: in expansion of macro 'TEST' 106 | #define LOAD_VSX_XFORM_TEST(op) TEST(op, op, stxvd2x, XFORM, 32, 32) | ^~~~ alignment_handler.c:342:2: note: in expansion of macro 'LOAD_VSX_XFORM_TEST' 342 | LOAD_VSX_XFORM_TEST(lxsspx); | ^~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_vsx_300': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:112:33: note: in expansion of macro 'TEST' 112 | #define LOAD_VMX_DFORM_TEST(op) TEST(op, op, stxv, DFORM, 0, 32) | ^~~~ alignment_handler.c:356:2: note: in expansion of macro 'LOAD_VMX_DFORM_TEST' 356 | LOAD_VMX_DFORM_TEST(lxsd); | ^~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_vsx_prefix': alignment_handler.c:104:2: error: 'rc' undeclared (first use in this function) 104 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:134:44: note: in expansion of macro 'TESTP' 134 | #define LOAD_VSX_8LS_PREFIX_TEST(op, tail) TESTP(op, op, PSTXV ## tail, 0, 32) | ^~~~~ alignment_handler.c:386:2: note: in expansion of macro 'LOAD_VSX_8LS_PREFIX_TEST' 386 | LOAD_VSX_8LS_PREFIX_TEST(PLXSD, 0); | ^~~~~~~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_integer': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:117:29: note: in expansion of macro 'TEST' 117 | #define LOAD_DFORM_TEST(op) TEST(op, op, std, DFORM, 31, 31) | ^~~~ alignment_handler.c:402:2: note: in expansion of macro 'LOAD_DFORM_TEST' 402 | LOAD_DFORM_TEST(lbz); | ^~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_integer_206': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:115:29: note: in expansion of macro 'TEST' 115 | #define LOAD_XFORM_TEST(op) TEST(op, op, stdx, XFORM, 31, 31) | ^~~~ alignment_handler.c:461:2: note: in expansion of macro 'LOAD_XFORM_TEST' 461 | LOAD_XFORM_TEST(ldbrx); | ^~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_integer_prefix': alignment_handler.c:104:2: error: 'rc' undeclared (first use in this function) 104 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:125:34: note: in expansion of macro 'TESTP' 125 | #define LOAD_MLS_PREFIX_TEST(op) TESTP(op, op, PSTD, 31, 31) | ^~~~~ alignment_handler.c:473:2: note: in expansion of macro 'LOAD_MLS_PREFIX_TEST' 473 | LOAD_MLS_PREFIX_TEST(PLBZ); | ^~~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_vmx': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:110:33: note: in expansion of macro 'TEST' 110 | #define LOAD_VMX_XFORM_TEST(op) TEST(op, op, stxvd2x, XFORM, 0, 32) | ^~~~ alignment_handler.c:492:2: note: in expansion of macro 'LOAD_VMX_XFORM_TEST' 492 | LOAD_VMX_XFORM_TEST(lvx); | ^~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_fp': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:120:36: note: in expansion of macro 'TEST' 120 | #define LOAD_FLOAT_DFORM_TEST(op) TEST(op, op, stfd, DFORM, 0, 0) | ^~~~ alignment_handler.c:517:2: note: in expansion of macro 'LOAD_FLOAT_DFORM_TEST' 517 | LOAD_FLOAT_DFORM_TEST(lfd); | ^~~~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_fp_205': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:120:36: note: in expansion of macro 'TEST' 120 | #define LOAD_FLOAT_DFORM_TEST(op) TEST(op, op, stfd, DFORM, 0, 0) | ^~~~ alignment_handler.c:545:2: note: in expansion of macro 'LOAD_FLOAT_DFORM_TEST' 545 | LOAD_FLOAT_DFORM_TEST(lfdp); | ^~~~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_fp_206': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:122:36: note: in expansion of macro 'TEST' 122 | #define LOAD_FLOAT_XFORM_TEST(op) TEST(op, op, stfdx, XFORM, 0, 0) | ^~~~ alignment_handler.c:561:2: note: in expansion of macro 'LOAD_FLOAT_XFORM_TEST' 561 | LOAD_FLOAT_XFORM_TEST(lfiwzx); | ^~~~~~~~~~~~~~~~~~~~~ alignment_handler.c: In function 'test_alignment_handler_fp_prefix': alignment_handler.c:93:2: error: 'rc' undeclared (first use in this function) 93 | rc |= do_test(#name, test_##name) | ^~ alignment_handler.c:120:36: note: in expansion of macro 'TEST' 120 | #define LOAD_FLOAT_DFORM_TEST(op) TEST(op, op, stfd, DFORM, 0, 0) | ^~~~ alignment_handler.c:573:2: note: in expansion of macro 'LOAD_FLOAT_DFORM_TEST' 573 | LOAD_FLOAT_DFORM_TEST(lfs); | ^~~~~~~~~~~~~~~~~~~~~ make[2]: *** [../../lib.mk:144: /output/kselftest/powerpc/alignment/alignment_handler] Error 1 make[2]: Target 'all' not remade because of errors. make[2]: Leaving directory '/linux/tools/testing/selftests/powerpc/alignment' make[1]: *** [Makefile:41: alignment] Error 2 make[1]: Leaving directory '/linux/tools/testing/selftests/powerpc' make: *** [Makefile:159: all] Error 2