From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3743C433ED for ; Fri, 23 Apr 2021 11:48:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC02A613AF for ; Fri, 23 Apr 2021 11:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbhDWLsk (ORCPT ); Fri, 23 Apr 2021 07:48:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:54020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhDWLsf (ORCPT ); Fri, 23 Apr 2021 07:48:35 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66D05613CB; Fri, 23 Apr 2021 11:47:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lZuHs-0093xp-CC; Fri, 23 Apr 2021 12:47:56 +0100 Date: Fri, 23 Apr 2021 12:47:55 +0100 Message-ID: <87r1j1nrx0.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: He Ying , tglx@linutronix.de, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] irqchip/gic-v3: Do not enable irqs when handling spurious interrups In-Reply-To: <20210423105051.GA83097@C02TD0UTHF1T.local> References: <20210423083516.170111-1-heying24@huawei.com> <20210423105051.GA83097@C02TD0UTHF1T.local> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, heying24@huawei.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Apr 2021 11:50:51 +0100, Mark Rutland wrote: [...] > > Fixes: 17ce302f3117 ("arm64: Fix interrupt tracing in the presence of NMIs") > > Signed-off-by: He Ying > > I'm reckon the fixes tag should probably be either: > > Fixes: f32c926651dcd168 ("irqchip/gic-v3: Handle pseudo-NMIs") > > ... or: > > Fixes: 3f1f3234bc2db1c1 (" irqchip/gic-v3: Switch to PMR masking before calling IRQ handler") > > ... since the underlying issue is that gic_handle_irq() unmasks DAIF.I > and permits unintended nesting, even if that doesn't trigger a BUG() at > that point. I used the latter (see 161917211934.29796.1841651233234902273.tip-bot2@tip-bot2). > Otherwise, this makes sense to me: > > Acked-by: Mark Rutland I'll update the commit to reflect this. Thanks. M. -- Without deviation from the norm, progress is not possible.