From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B96C433DB for ; Thu, 14 Jan 2021 10:45:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0478523A3B for ; Thu, 14 Jan 2021 10:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728623AbhANKpa (ORCPT ); Thu, 14 Jan 2021 05:45:30 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:21888 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbhANKp3 (ORCPT ); Thu, 14 Jan 2021 05:45:29 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610621110; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=OjjfXZal6B47GNRAOFXmbhnpHD2u3Oq2qC6Px4eVK1Q=; b=EfVD2TQ25/DZNXgvZZ7pnmBi9pmBZnpZyRBStbBDAtJAUrx3D9OOMEY91b7CVwK+bEaefo51 1KRfGnHiywEiB5SMG+bHkCv0k10cRQ+cmzubBY09oVD5CEqSazjI+PBhlFsXZ/SvI0tx2e3P PNsGPd4oe7urIZy9Y35Nk7/VCeA= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-east-1.postgun.com with SMTP id 600020978fb3cda82f3ce0c5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 14 Jan 2021 10:44:39 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 47896C43464; Thu, 14 Jan 2021 10:44:38 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E11AFC433CA; Thu, 14 Jan 2021 10:44:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E11AFC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: Arnd Bergmann , Felix Fietkau , Lorenzo Bianconi , Arnd Bergmann , Ryder Lee , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Shayne Chen , Yiwei Chung , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt76: mt7915: fix misplaced #ifdef References: <20210103135811.3749775-1-arnd@kernel.org> <20210106135801.GA27377@meh.true.cz> Date: Thu, 14 Jan 2021 12:44:31 +0200 In-Reply-To: <20210106135801.GA27377@meh.true.cz> ("Petr \=\?utf-8\?Q\?\=C5\=A0t\?\= \=\?utf-8\?Q\?etiar\=22's\?\= message of "Wed, 6 Jan 2021 14:58:01 +0100") Message-ID: <87r1mnhk6o.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Petr =C5=A0tetiar writes: > Arnd Bergmann [2021-01-03 14:57:55]: > > Hi, > > just a small nitpick, > >> From: Arnd Bergmann >>=20 >> The lone '|' at the end of a line causes a build failure: >>=20 >> drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error: >> expected expression before '}' token >>=20 >> Replace the #ifdef with an equivalent IS_ENABLED() check. >>=20 >> Fixes: af901eb4ab80 ("mt76: mt7915: get rid of dbdc debugfs knob") > > I think, that the correct fixes tag is following: > > Fixes: 8aa2c6f4714e ("mt76: mt7915: support 32 station interfaces") > > I've used the af901eb4ab80 as well first in > https://github.com/openwrt/mt76/pull/490 but then looked at it once more = and > actually found the probably correct 8aa2c6f4714e. Ok, I'll change that during commit. Felix, I'm planning to apply this to wireless-drivers and assigned this to me in patchwork. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes