From: "Alex Bennée" <alex.bennee@linaro.org>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
christoffer.dall@arm.com
Subject: Re: [PATCH v1 3/3] kernel/configs: don't include PCI_QUIRKS in KVM guest configs
Date: Tue, 04 Aug 2020 15:44:58 +0100 [thread overview]
Message-ID: <87r1smmpw5.fsf@linaro.org> (raw)
In-Reply-To: <f80cfa932a650d8f7e8fc02a1656b4c2@kernel.org>
Marc Zyngier <maz@kernel.org> writes:
> On 2020-08-04 13:44, Alex Bennée wrote:
>> The VIRTIO_PCI support is an idealised PCI bus, we don't need a bunch
>> of bloat for real world hardware for a VirtIO guest.
>
> Who says this guest will only have virtio devices?
This is true - although what is the point of kvm_guest.config? We
certainly turn on a whole bunch of virt optimised pathways with PARAVIRT
and HYPERVISOR_GUEST along with the rest of VirtIO.
> Or even, virtio devices without bugs? Given that said device can
> come from any VMM, I'm not sure this is the right thing to do.
Perhaps this patch is one too far. I don't mind dropping it as long as I
can still slim down the kernels I know don't need the extra bloat.
>
> Thanks,
>
> M.
>
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> kernel/configs/kvm_guest.config | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/configs/kvm_guest.config
>> b/kernel/configs/kvm_guest.config
>> index 208481d91090..672863a2fdf1 100644
>> --- a/kernel/configs/kvm_guest.config
>> +++ b/kernel/configs/kvm_guest.config
>> @@ -13,6 +13,7 @@ CONFIG_IP_PNP_DHCP=y
>> CONFIG_BINFMT_ELF=y
>> CONFIG_PCI=y
>> CONFIG_PCI_MSI=y
>> +CONFIG_PCI_QUIRKS=n
>> CONFIG_DEBUG_KERNEL=y
>> CONFIG_VIRTUALIZATION=y
>> CONFIG_HYPERVISOR_GUEST=y
--
Alex Bennée
next prev parent reply other threads:[~2020-08-04 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 12:44 [RFC PATCH v1 0/3] put arm64 kvm_config on a diet Alex Bennée
2020-08-04 12:44 ` [PATCH v1 1/3] arm64: allow de-selection of ThunderX PCI controllers Alex Bennée
2020-08-17 17:11 ` Bjorn Helgaas
2020-08-04 12:44 ` [PATCH v1 2/3] arm64: gate the whole of pci-xgene on CONFIG_PCI_XGENE Alex Bennée
2020-08-04 12:44 ` [PATCH v1 3/3] kernel/configs: don't include PCI_QUIRKS in KVM guest configs Alex Bennée
2020-08-04 13:46 ` Marc Zyngier
2020-08-04 14:44 ` Alex Bennée [this message]
2020-08-04 14:59 ` Marc Zyngier
2020-08-04 15:40 ` Alex Bennée
2020-08-04 17:16 ` Marc Zyngier
2020-08-04 13:18 ` [RFC PATCH v1 0/3] put arm64 kvm_config on a diet Ard Biesheuvel
2020-08-04 14:47 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1smmpw5.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=christoffer.dall@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).