LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] ath10k: Enable QDSS clock on sm8150
@ 2019-12-23  5:48 Bjorn Andersson
  2019-12-23  5:48 ` [PATCH 1/2] ath10k: Add optional qdss clk Bjorn Andersson
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Bjorn Andersson @ 2019-12-23  5:48 UTC (permalink / raw)
  To: Kalle Valo, David S. Miller, Rob Herring, Mark Rutland,
	Andy Gross, Bjorn Andersson
  Cc: linux-wireless, netdev, devicetree, linux-kernel, linux-arm-msm, ath10k

On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
will reset due to an NoC error. So this adds an optional clock to the ath10k
binding and makes sure it's enabled while the WiFi firmware needs it.

Bjorn Andersson (2):
  ath10k: Add optional qdss clk
  arm64: dts: qcom: sm8150: Specify qdss clock for wifi

 .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
 arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
 drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.24.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] ath10k: Add optional qdss clk
  2019-12-23  5:48 [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Bjorn Andersson
@ 2019-12-23  5:48 ` Bjorn Andersson
  2020-01-08 16:25   ` Rob Herring
  2019-12-23  5:48 ` [PATCH 2/2] arm64: dts: qcom: sm8150: Specify qdss clock for wifi Bjorn Andersson
  2020-01-10  7:16 ` [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Kalle Valo
  2 siblings, 1 reply; 7+ messages in thread
From: Bjorn Andersson @ 2019-12-23  5:48 UTC (permalink / raw)
  To: Kalle Valo, David S. Miller, Rob Herring, Mark Rutland
  Cc: Andy Gross, linux-wireless, netdev, devicetree, linux-kernel,
	linux-arm-msm, ath10k

The WiFi firmware found on sm8150 requires that the QDSS clock is
ticking in order to operate, so add an optional clock to the binding to
allow this to be specified in the sm8150 dts and add the clock to the
list of clocks in the driver.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 2 +-
 drivers/net/wireless/ath/ath10k/snoc.c                         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index 017128394a3e..3fc2cce4626b 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -50,7 +50,7 @@ Optional properties:
           entry in clock-names.
 - clock-names: Should contain the clock names "wifi_wcss_cmd", "wifi_wcss_ref",
 	       "wifi_wcss_rtc" for "qcom,ipq4019-wifi" compatible target and
-	       "cxo_ref_clk_pin" for "qcom,wcn3990-wifi"
+	       "cxo_ref_clk_pin" and optionally "qdss" for "qcom,wcn3990-wifi"
 	       compatible target.
 - qcom,msi_addr: MSI interrupt address.
 - qcom,msi_base: Base value to add before writing MSI data into
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index 7e85c4916e7f..aeb4cca92c35 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -46,7 +46,7 @@ static const char * const ath10k_regulators[] = {
 };
 
 static const char * const ath10k_clocks[] = {
-	"cxo_ref_clk_pin",
+	"cxo_ref_clk_pin", "qdss",
 };
 
 static void ath10k_snoc_htc_tx_cb(struct ath10k_ce_pipe *ce_state);
-- 
2.24.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sm8150: Specify qdss clock for wifi
  2019-12-23  5:48 [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Bjorn Andersson
  2019-12-23  5:48 ` [PATCH 1/2] ath10k: Add optional qdss clk Bjorn Andersson
@ 2019-12-23  5:48 ` Bjorn Andersson
  2020-01-10  7:16 ` [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Kalle Valo
  2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2019-12-23  5:48 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland
  Cc: Kalle Valo, David S. Miller, Andy Gross, linux-wireless, netdev,
	devicetree, linux-kernel, linux-arm-msm, ath10k

The WiFi firmware on SM8150 requires the QDSS clock to be ticking, so
specify this clock for the wifi node.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 373fa098ebb2..0f0c9db3d484 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -929,8 +929,8 @@ wifi: wifi@18800000 {
 			reg = <0 0x18800000 0 0x800000>;
 			reg-names = "membase";
 			memory-region = <&wlan_mem>;
-			clock-names = "cxo_ref_clk_pin";
-			clocks = <&rpmhcc RPMH_RF_CLK2>;
+			clock-names = "cxo_ref_clk_pin", "qdss";
+			clocks = <&rpmhcc RPMH_RF_CLK2>, <&aoss_qmp>;
 			interrupts = <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.24.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] ath10k: Add optional qdss clk
  2019-12-23  5:48 ` [PATCH 1/2] ath10k: Add optional qdss clk Bjorn Andersson
@ 2020-01-08 16:25   ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2020-01-08 16:25 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Kalle Valo, David S. Miller, Mark Rutland, Andy Gross,
	linux-wireless, netdev, devicetree, linux-kernel, linux-arm-msm,
	ath10k

On Sun, 22 Dec 2019 21:48:54 -0800, Bjorn Andersson wrote:
> The WiFi firmware found on sm8150 requires that the QDSS clock is
> ticking in order to operate, so add an optional clock to the binding to
> allow this to be specified in the sm8150 dts and add the clock to the
> list of clocks in the driver.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 2 +-
>  drivers/net/wireless/ath/ath10k/snoc.c                         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/2] ath10k: Enable QDSS clock on sm8150
  2019-12-23  5:48 [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Bjorn Andersson
  2019-12-23  5:48 ` [PATCH 1/2] ath10k: Add optional qdss clk Bjorn Andersson
  2019-12-23  5:48 ` [PATCH 2/2] arm64: dts: qcom: sm8150: Specify qdss clock for wifi Bjorn Andersson
@ 2020-01-10  7:16 ` Kalle Valo
  2020-01-15  9:04   ` Kalle Valo
  2 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2020-01-10  7:16 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: David S. Miller, Rob Herring, Mark Rutland, Andy Gross,
	linux-wireless, netdev, devicetree, linux-kernel, linux-arm-msm,
	ath10k

Bjorn Andersson <bjorn.andersson@linaro.org> writes:

> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
> will reset due to an NoC error. So this adds an optional clock to the ath10k
> binding and makes sure it's enabled while the WiFi firmware needs it.
>
> Bjorn Andersson (2):
>   ath10k: Add optional qdss clk
>   arm64: dts: qcom: sm8150: Specify qdss clock for wifi
>
>  .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
>  arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
>  drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

Via which tree are these supposed to go? I'll take patch 1 and arm
mantainers take patch 2, or what?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/2] ath10k: Enable QDSS clock on sm8150
  2020-01-10  7:16 ` [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Kalle Valo
@ 2020-01-15  9:04   ` Kalle Valo
  2020-01-15 19:19     ` Bjorn Andersson
  0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2020-01-15  9:04 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Mark Rutland, devicetree, netdev, linux-wireless, linux-kernel,
	Rob Herring, Andy Gross, ath10k, linux-arm-msm, David S. Miller

Kalle Valo <kvalo@codeaurora.org> writes:

> Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>
>> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
>> will reset due to an NoC error. So this adds an optional clock to the ath10k
>> binding and makes sure it's enabled while the WiFi firmware needs it.
>>
>> Bjorn Andersson (2):
>>   ath10k: Add optional qdss clk
>>   arm64: dts: qcom: sm8150: Specify qdss clock for wifi
>>
>>  .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
>>  arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
>>  drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
>>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> Via which tree are these supposed to go? I'll take patch 1 and arm
> mantainers take patch 2, or what?

No reply, so I'm planning to take patch 1. Please holler if I
misunderstood.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/2] ath10k: Enable QDSS clock on sm8150
  2020-01-15  9:04   ` Kalle Valo
@ 2020-01-15 19:19     ` Bjorn Andersson
  0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2020-01-15 19:19 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Mark Rutland, devicetree, netdev, linux-wireless, linux-kernel,
	Rob Herring, Andy Gross, ath10k, linux-arm-msm, David S. Miller

On Wed 15 Jan 01:04 PST 2020, Kalle Valo wrote:

> Kalle Valo <kvalo@codeaurora.org> writes:
> 
> > Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> >
> >> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
> >> will reset due to an NoC error. So this adds an optional clock to the ath10k
> >> binding and makes sure it's enabled while the WiFi firmware needs it.
> >>
> >> Bjorn Andersson (2):
> >>   ath10k: Add optional qdss clk
> >>   arm64: dts: qcom: sm8150: Specify qdss clock for wifi
> >>
> >>  .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
> >>  arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
> >>  drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
> >>  3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > Via which tree are these supposed to go? I'll take patch 1 and arm
> > mantainers take patch 2, or what?

That sounds good (you take the ath10k and we'll take the dts).

> 
> No reply, so I'm planning to take patch 1. Please holler if I
> misunderstood.
> 

Sorry.

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23  5:48 [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Bjorn Andersson
2019-12-23  5:48 ` [PATCH 1/2] ath10k: Add optional qdss clk Bjorn Andersson
2020-01-08 16:25   ` Rob Herring
2019-12-23  5:48 ` [PATCH 2/2] arm64: dts: qcom: sm8150: Specify qdss clock for wifi Bjorn Andersson
2020-01-10  7:16 ` [PATCH 0/2] ath10k: Enable QDSS clock on sm8150 Kalle Valo
2020-01-15  9:04   ` Kalle Valo
2020-01-15 19:19     ` Bjorn Andersson

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git