linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: ll_temac: Remove set but not used variable 'start_p'
@ 2019-11-10 10:39 Zheng Yongjun
  2019-11-11 12:34 ` Esben Haabendal
  0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2019-11-10 10:39 UTC (permalink / raw)
  To: davem, michal.simek, esben, andrew
  Cc: linux-kernel, zhengyongjun3, Hulk Robot

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/xilinx/ll_temac_main.c: In function temac_start_xmit:
drivers/net/ethernet/xilinx/ll_temac_main.c:737:13: warning: variable start_p set but not used [-Wunused-but-set-variable]

start_p is never used, so remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 21c1b4322ea7..b37433be6b7f 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -819,14 +819,13 @@ temac_start_xmit(struct sk_buff *skb, struct net_device *ndev)
 {
 	struct temac_local *lp = netdev_priv(ndev);
 	struct cdmac_bd *cur_p;
-	dma_addr_t start_p, tail_p, skb_dma_addr;
+	dma_addr_t tail_p, skb_dma_addr;
 	int ii;
 	unsigned long num_frag;
 	skb_frag_t *frag;
 
 	num_frag = skb_shinfo(skb)->nr_frags;
 	frag = &skb_shinfo(skb)->frags[0];
-	start_p = lp->tx_bd_p + sizeof(*lp->tx_bd_v) * lp->tx_bd_tail;
 	cur_p = &lp->tx_bd_v[lp->tx_bd_tail];
 
 	if (temac_check_tx_bd_space(lp, num_frag + 1)) {
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ll_temac: Remove set but not used variable 'start_p'
  2019-11-10 10:39 [PATCH] net: ll_temac: Remove set but not used variable 'start_p' Zheng Yongjun
@ 2019-11-11 12:34 ` Esben Haabendal
  0 siblings, 0 replies; 2+ messages in thread
From: Esben Haabendal @ 2019-11-11 12:34 UTC (permalink / raw)
  To: Zheng Yongjun; +Cc: linux-kernel, Hulk Robot

Zheng Yongjun <zhengyongjun3@huawei.com> writes:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/xilinx/ll_temac_main.c: In function temac_start_xmit:
> drivers/net/ethernet/xilinx/ll_temac_main.c:737:13: warning: variable start_p set but not used [-Wunused-but-set-variable]
>
> start_p is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Acked-by: Esben Haabendal <esben@geanix.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-11 12:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-10 10:39 [PATCH] net: ll_temac: Remove set but not used variable 'start_p' Zheng Yongjun
2019-11-11 12:34 ` Esben Haabendal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).