From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] realtek: no need to check return value of debugfs_create functions
Date: Tue, 22 Jan 2019 17:48:51 +0200 [thread overview]
Message-ID: <87r2d4n15o.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <c09a1fb9-45e4-c21e-3c19-09ba94ebd859@lwfinger.net> (Larry Finger's message of "Tue, 22 Jan 2019 09:44:37 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 1/22/19 9:21 AM, Greg Kroah-Hartman wrote:
>> When calling debugfs functions, there is no need to ever check the
>> return value. The function can work or not, but the code logic should
>> never do something different based on this.
>>
>> Cc: Ping-Ke Shih <pkshih@realtek.com>
>> Cc: Kalle Valo <kvalo@codeaurora.org>
>> Cc: linux-wireless@vger.kernel.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Greg,
>
> Please change the subject to read "rtlwifi: ...". Otherwise the patch is correct.
I can fix that during commit.
--
Kalle Valo
next prev parent reply other threads:[~2019-01-22 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] realtek: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 15:44 ` Larry Finger
2019-01-22 15:48 ` Kalle Valo [this message]
2019-02-01 12:33 ` [PATCH] rtlwifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2d4n15o.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).