From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
David Binderman <dcb314@hotmail.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Julien Thierry <julien.thierry@arm.com>
Subject: Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error
Date: Sat, 10 Nov 2018 18:54:42 +0100 [thread overview]
Message-ID: <87r2fslswt.fsf@belgarion.home> (raw)
In-Reply-To: <20181106163724.GK30658@n2100.armlinux.org.uk> (Russell King's message of "Tue, 6 Nov 2018 16:37:24 +0000")
Russell King - ARM Linux <linux@armlinux.org.uk> writes:
>> Interestingly, more of the same in file linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c
>>
>> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:84]: (warning) Redundant assignment of 'ASCR' to itself.
>> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:85]: (warning) Redundant assignment of 'ARSR' to itself.
>> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:120]: (warning) Redundant assignment of 'ASCR' to itself.
>> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:121]: (warning) Redundant assignment of 'ARSR' to itself.
>>
>> I don't know if these four are also worth fixing.
>
> There are cases where this can be false positives. In the case of a
> status register with write-1-to-clear bits for example. These ones
> look very much like that.
And indeed they are, for bits 2,1,0 for ASCR and 3,2,1,0 for ARSR, and you
guessed correctly they are partly status registers.
If only your checker could filter out __iomem tagged pointers, you could have
far less of these false positives ...
Cheers.
--
Robert
prev parent reply other threads:[~2018-11-10 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR08MB3342D4ADBFBC43F2BE2FD34D9CCA0@VI1PR08MB3342.eurprd08.prod.outlook.com>
[not found] ` <VI1PR08MB33420789A2AA1096D3F5FC9D9CCA0@VI1PR08MB3342.eurprd08.prod.outlook.com>
2018-11-06 16:20 ` linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error Russell King - ARM Linux
2018-11-06 16:29 ` Julien Thierry
2018-11-06 16:39 ` Russell King - ARM Linux
2018-11-06 16:44 ` Julien Thierry
[not found] ` <VI1PR08MB33427CD1C653245DBB979B9B9CCB0@VI1PR08MB3342.eurprd08.prod.outlook.com>
2018-11-06 16:37 ` Russell King - ARM Linux
2018-11-10 17:54 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2fslswt.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=dcb314@hotmail.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).