From: Andi Kleen <ak@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
y2038@lists.linaro.org, Andi Kleen <andi.kleen@intel.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jeff Layton <jlayton@redhat.com>, Jan Kara <jack@suse.cz>,
Brian Foster <bfoster@redhat.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>, Jens Axboe <axboe@kernel.dk>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: replace current_kernel_time64 with ktime equivalent
Date: Wed, 20 Jun 2018 08:40:55 -0700 [thread overview]
Message-ID: <87r2l1sby0.fsf@linux.intel.com> (raw)
In-Reply-To: <20180620150138.49380-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 20 Jun 2018 17:01:24 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
>
> I traced the original addition of the current_kernel_time() call to set
> the nanosecond fields back to linux-2.5.48, where Andi Kleen added a
> patch with subject "nanosecond stat timefields". This adds the original
> call to current_kernel_time and the truncation to the resolution of the
> file system, but makes no mention of the intended accuracy. At the time,
> we had a do_gettimeofday() interface that on some architectures could
> return a microsecond-resolution timestamp, but there was no interface
> for getting an accurate timestamp in nanosecond resolution, neither inside
> the kernel nor from user space. This makes me suspect that the use of
> coarse timestamps was never really a conscious decision but instead
> a result of whatever API was available 16 years ago.
Kind of. VFS/system calls are expensive enough that you need multiple us
in and out so us resolution was considered good enough.
Also if you do this change you really need to do some benchmarks,
especially on setups without lazy atime. This might potentially
cause a lot more inode flushes.
-Andi
next prev parent reply other threads:[~2018-06-20 15:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 15:01 [PATCH] vfs: replace current_kernel_time64 with ktime equivalent Arnd Bergmann
2018-06-20 15:40 ` Andi Kleen [this message]
2018-06-20 16:14 ` Arnd Bergmann
2018-06-20 16:19 ` Andi Kleen
2018-06-20 19:35 ` Arnd Bergmann
2018-06-25 13:42 ` Arnd Bergmann
2018-06-21 20:23 ` Dave Chinner
2018-06-22 13:24 ` Arnd Bergmann
2018-06-26 0:24 ` Dave Chinner
2018-06-26 16:08 ` [Y2038] " Arnd Bergmann
2018-07-26 13:07 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2l1sby0.fsf@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=deepa.kernel@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=pasha.tatashin@oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).