From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753387AbdDZR1D (ORCPT ); Wed, 26 Apr 2017 13:27:03 -0400 Received: from anholt.net ([50.246.234.109]:53892 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbdDZR0s (ORCPT ); Wed, 26 Apr 2017 13:26:48 -0400 From: Eric Anholt To: Florian Fainelli , Vivien Didelot , Andrew Lunn , netdev@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , Jon Mason Subject: Re: [PATCH v2 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT. In-Reply-To: <0cb00eb7-41d0-0390-4687-d966499ed9f4@gmail.com> References: <20170425235357.7690-1-eric@anholt.net> <20170425235357.7690-2-eric@anholt.net> <0cb00eb7-41d0-0390-4687-d966499ed9f4@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 26 Apr 2017 10:26:44 -0700 Message-ID: <87r30fjd0r.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Florian Fainelli writes: > On 04/25/2017 04:53 PM, Eric Anholt wrote: >> Cygnus has a single AMAC controller connected to the B53 switch with 2 >> PHYs. On the BCM911360_EP platform, those two PHYs are connected to >> the external ethernet jacks. >>=20 >> Signed-off-by: Eric Anholt >> Reviewed-by: Florian Fainelli >> --- >>=20 >> v2: Call the node "switch", just call the ports "port" (suggestions by >> Florian), drop max-speed on the phys (suggestion by Andrew Lunn), >> call the other nodes "ethernet" and "ethernet-phy" (suggestions by >> Sergei Shtylyov) >>=20 >> arch/arm/boot/dts/bcm-cygnus.dtsi | 58 +++++++++++++++++++++++++++= +++++++ >> arch/arm/boot/dts/bcm911360_entphn.dts | 8 +++++ >> 2 files changed, 66 insertions(+) >>=20 >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-c= ygnus.dtsi >> index 009f1346b817..9fd89be0f5e0 100644 >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi >> @@ -142,6 +142,54 @@ >> interrupts =3D <0>; >> }; >>=20=20 >> + mdio: mdio@18002000 { >> + compatible =3D "brcm,iproc-mdio"; >> + reg =3D <0x18002000 0x8>; >> + #size-cells =3D <1>; >> + #address-cells =3D <0>; > > Sorry for not noticing earlier, since you override this correctly in the > board-level DTS file can you put a: > > status =3D "disabled" > > property in there by default? Done. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlkA2FQACgkQtdYpNtH8 nuiG+RAAulmpDX7UD+c7qEvexcyuJLr7fZ5PPTXRXYmowA6JercWM3p3f+TQr/E8 wEGP6zDKR017Ov77ubuQdMyPaiXXbAlVsD788gcP7s6+B2DDn7w6UOIIu+4O+xrD gt2a8ZbHnua9HCeupvTjHptU0e+459QV/1U9DNnF9xfF32dptEWx7/vK/cQfsOeC 3ODouOTXBOVSatFLyyyW1TDr8wvQ2uCNaDuhmtzmRjfYwM3u78aQk0dRjxBFAw36 oUHF2mHPeRuhu/USPs9qAa7gfSXkeVMwgTlKB3QzY/mNkCEt+p8mrhCw46Xa16yc 9WpkZg/U5bCUCdZDx79epYOFHAc7jJHX4Bs52zEmipivXTI+0ANT0E1KtXqPJjkd xpqOj/bcKzhDNJ5azXygx7iqyefMdfcEecQ21FU25UbgW85V0/D/5DKVr5+gLuYX P+F6bxxaOIicncbufiiEBpA6USepC+8h9CCfkMuClGRwM59FceNFTvvFDaJDn/1t rP6a2uV39ui03WAEjYaVEK4N1g3jySv19f6j8x43aRo7v5em8g1lNJHU5ylMGGtD kEoYvkBbh7lb8YL1PIqm7TT4dR/ai6g/JgjKs9f5zVo08Fdr3o8MJfNzQMRBUCFd uOhxYLgzYuPjWtfV5xTfVk30Z7gEpngodJ9KyijZdHC/VkG9hX8= =IcQ2 -----END PGP SIGNATURE----- --=-=-=--