From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fat: Fix oops on corrupted vfat fs
Date: Thu, 27 Nov 2014 16:00:41 +0900 [thread overview]
Message-ID: <87r3wpw2jq.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20141126142805.396bda184367db070f6321d5@linux-foundation.org> (Andrew Morton's message of "Wed, 26 Nov 2014 14:28:05 -0800")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
>
>> a) don't bother with ->d_time for positives - we only check it for negatives
>> anyway.
>> b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be
>> negative dentry matches then-current directory contents
>> c) don't go into renaming of old alias in vfat_lookup() unless it has
>> the same parent (which it will, unless we are seeing corrupted image)
>>
>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>> Cc: <stable@vger.kernel.org> # 3.17.x
>> [Make change minimum, don't call d_move() for dir]
>> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
> It's unclear who did the "[Make change minimum.." alteration.
>
> I do it this way:
> [hirofumi@mail.parknet.co.jp: make change minimum, don't call d_move() for dir]
I see. OK, I will also use your format next time.
> Also, who was the primary author of this patch? It *looks* like it was
> Al, unsure. If it was indeed Al then this can be communicated by
> putting his From: line at the very top of the changelog body.
Ah, sorry. The patch is written by Al, and I was forgetting to add "From:".
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2014-11-27 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 15:31 [PATCH] fat: Fix oops on corrupted vfat fs OGAWA Hirofumi
2014-11-26 22:28 ` Andrew Morton
2014-11-27 7:00 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3wpw2jq.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).