From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <maz@kernel.org>, linux-kernel@vger.kernel.org
Cc: John Garry <john.garry@huawei.com>,
David Decotigny <ddecotig@google.com>
Subject: Re: [PATCH] genirq/msi: Shutdown managed interrupts with unsatifiable affinities
Date: Mon, 14 Mar 2022 16:27:10 +0100 [thread overview]
Message-ID: <87sfrkftbl.ffs@tglx> (raw)
In-Reply-To: <20220307190625.254426-1-maz@kernel.org>
On Mon, Mar 07 2022 at 19:06, Marc Zyngier wrote:
> When booting with maxcpus=<small number>, interrupt controllers
> such as the GICv3 ITS may not be able to satisfy the affinity of
> some managed interrupts, as some of the HW resources are simply
> not available.
This is also true if you have offlined lots of CPUs, right?
> In order to deal with this, do not try to activate such interrupt
> if there is no online CPU capable of handling it. Instead, place
> it in shutdown state. Once a capable CPU shows up, it will be
> activated.
>
> Reported-by: John Garry <john.garry@huawei.com>
> Reported-by: David Decotigny <ddecotig@google.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> kernel/irq/msi.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
> index 2bdfce5edafd..aa84ce84c2ec 100644
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -818,6 +818,18 @@ static int msi_init_virq(struct irq_domain *domain, int virq, unsigned int vflag
> irqd_clr_can_reserve(irqd);
> if (vflags & VIRQ_NOMASK_QUIRK)
> irqd_set_msi_nomask_quirk(irqd);
> +
> + /*
> + * If the interrupt is managed but no CPU is available
> + * to service it, shut it down until better times.
> + */
> + if ((vflags & VIRQ_ACTIVATE) &&
> + irqd_affinity_is_managed(irqd) &&
> + !cpumask_intersects(irq_data_get_affinity_mask(irqd),
> + cpu_online_mask)) {
> + irqd_set_managed_shutdown(irqd);
Hrm. Why is this in the !CAN_RESERVE path and not before the actual
activation call?
Thanks,
tglx
next prev parent reply other threads:[~2022-03-14 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 19:06 [PATCH] genirq/msi: Shutdown managed interrupts with unsatifiable affinities Marc Zyngier
2022-03-08 1:34 ` David Decotigny
2022-03-09 10:20 ` John Garry
2022-03-10 3:24 ` Xiongfeng Wang
2022-03-10 6:11 ` Xiongfeng Wang
2022-03-14 15:27 ` Thomas Gleixner [this message]
2022-03-14 16:00 ` Marc Zyngier
2022-03-14 19:03 ` Thomas Gleixner
2022-03-15 9:46 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfrkftbl.ffs@tglx \
--to=tglx@linutronix.de \
--cc=ddecotig@google.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).