From: Marc Zyngier <maz@kernel.org>
To: qinjian <qinjian@cqplus1.com>
Cc: tglx@linutronix.de, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller
Date: Sat, 23 Oct 2021 10:05:57 +0100 [thread overview]
Message-ID: <87sfwst8ju.wl-maz@kernel.org> (raw)
In-Reply-To: <20211022060737.281116-1-qinjian@cqplus1.com>
On Fri, 22 Oct 2021 07:07:37 +0100,
qinjian <qinjian@cqplus1.com> wrote:
>
> Add documentation to describe Sunplus SP7021 interrupt controller bindings.
>
> Signed-off-by: qinjian <qinjian@cqplus1.com>
> ---
> .../sunplus,sp7021-intc.yaml | 69 +++++++++++++++++++
> MAINTAINERS | 2 +
> .../interrupt-controller/sp7021-intc.h | 24 +++++++
> 3 files changed, 95 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> create mode 100644 include/dt-bindings/interrupt-controller/sp7021-intc.h
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> new file mode 100644
> index 000000000..73719f65b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/sunplus,sp7021-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SP7021 SoC Interrupt Controller Device Tree Bindings
> +
> +maintainers:
> + - Qin Jian <qinjian@cqplus1.com>
> +
> +properties:
> + compatible:
> + items:
> + - const: sunplus,sp7021-intc
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description:
> + Interrupts references to primary interrupt controller
> +
> + ext0-mask:
> + description:
> + cpu affinity of EXT_INT0.
> + $ref: "/schemas/types.yaml#/definitions/uint32"
> + minimum: 1
> + maximum: 16
That's not a description of the HW. This is just a SW policy that
trickles into the DT. The output interrupt is simply connected to the
parent interrupt controller, and how it is routed is out of the scope
of the DT. This (and its ext1 sibling) should be dropped.
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2021-10-23 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 6:07 [PATCH 2/4] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller qinjian
2021-10-22 14:03 ` Rob Herring
2021-10-22 23:25 ` Rob Herring
2021-10-23 9:05 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfwst8ju.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).