From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE12C4338F for ; Wed, 4 Aug 2021 08:50:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92F5860F6F for ; Wed, 4 Aug 2021 08:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236727AbhHDIuZ (ORCPT ); Wed, 4 Aug 2021 04:50:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:42628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236692AbhHDIuW (ORCPT ); Wed, 4 Aug 2021 04:50:22 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80E3660E97; Wed, 4 Aug 2021 08:50:10 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mBCbI-002sOl-HQ; Wed, 04 Aug 2021 09:50:08 +0100 Date: Wed, 04 Aug 2021 09:50:08 +0100 Message-ID: <87sfzpwq4f.wl-maz@kernel.org> From: Marc Zyngier To: Saravana Kannan Cc: Kevin Hilman , Lee Jones , Neil Armstrong , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-arm-kernel , open list Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module In-Reply-To: References: <20201020072532.949137-1-narmstrong@baylibre.com> <20201020072532.949137-2-narmstrong@baylibre.com> <7hsga8kb8z.fsf@baylibre.com> <87r1hwwier.wl-maz@kernel.org> <7h7diwgjup.fsf@baylibre.com> <87im0m277h.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: saravanak@google.com, khilman@baylibre.com, lee.jones@linaro.org, narmstrong@baylibre.com, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Aug 2021 02:36:45 +0100, Saravana Kannan wrote: Hi Saravana, Thanks for looking into this. [...] > > Saravana, could you please have a look from a fw_devlink perspective? > > Sigh... I spent several hours looking at this and wrote up an analysis > and then realized I might be looking at the wrong DT files. > > Marc, can you point me to the board file in upstream that corresponds > to the platform in which you see this issue? I'm not asking for [1], > but the actual final .dts (not .dtsi) file that corresponds to the > platform/board/system. The platform I can reproduce this on is described in arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts. It is an intricate maze of inclusion, node merge and other DT subtleties. I suggest you look at the decompiled version to get a view of the result. > Based on your error messages, it's failing for mdio@0 which > corresponds to ext_mdio. But none of the board dts files in upstream > have a compatible property for "ext_mdio". Which means fw_devlink > _should_ propagate the gpio_intc IRQ dependency all the way up to > eth_phy. > > Also, in the failing case, can you run: > ls -ld supplier:* > > in the /sys/devices/..../ folder that corresponds to the > "eth_phy: mdio-multiplexer@4c000" DT node and tell me what it shows? Here you go: root@tiger-roach:~# find /sys/devices/ -name 'supplier*'|grep -i mdio | xargs ls -ld lrwxrwxrwx 1 root root 0 Aug 4 09:47 /sys/devices/platform/soc/ff600000.bus/ff64c000.mdio-multiplexer/supplier:platform:ff63c000.system-controller:clock-controller -> ../../../../virtual/devlink/platform:ff63c000.system-controller:clock-controller--platform:ff64c000.mdio-multiplexer lrwxrwxrwx 1 root root 0 Aug 4 09:47 /sys/devices/virtual/devlink/platform:ff63c000.system-controller:clock-controller--platform:ff64c000.mdio-multiplexer/supplier -> ../../../platform/soc/ff600000.bus/ff63c000.bus/ff63c000.system-controller/ff63c000.system-controller:clock-controller Thanks, M. -- Without deviation from the norm, progress is not possible.