linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Egorenkov <egorenar@linux.ibm.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux@rasmusvillemoes.dk
Cc: akpm@linux-foundation.org, bp@alien8.de, corbet@lwn.net,
	gregkh@linuxfoundation.org, jeyu@kernel.org,
	linux-kernel@vger.kernel.org, mcgrof@kernel.org,
	ndesaulniers@google.com, torvalds@linux-foundation.org,
	Bruno Goncalves <bgoncalv@redhat.com>,
	Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH v3 1/2] init/initramfs.c: do unpacking asynchronously
Date: Wed, 28 Jul 2021 12:36:50 +0200	[thread overview]
Message-ID: <87sfzyg1x9.fsf@oc8242746057.ibm.com> (raw)
In-Reply-To: <edb79b68-6dd0-ced5-17a0-fda7516d3529@rasmusvillemoes.dk>
In-Reply-To: 

Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:

> On 24/07/2021 09.46, Alexander Egorenkov wrote:
>> Hello,
>> 
>> since e7cb072eb988 ("init/initramfs.c: do unpacking asynchronously"), we
>> started seeing the following problem on s390 arch regularly:
>> 
>> [    5.039734] wait_for_initramfs() called before rootfs_initcalls
>
> While that message was added as part of the same patch, it's a red
> herring: It merely means that something ends up calling usermodehelper
> (perhaps a request_module) before the init sequence has come around to
> rootfs_initcalls. At that point, the rootfs is (with or without my async
> patch) entirely empty, so those usermodehelper calls have always failed
> with -ENOENT.
>
> If you have CONFIG_UEVENT_HELPER=y and CONFIG_UEVENT_HELPER_PATH set to
> a non-empty string, you can try setting the latter to the empty string.
> But the message won't go away if it's really a request_module() and not
> a uevent notification.
>

Thanks for the helpful explanation. I disabled UEVENT on my test machine and
as you said, the message is being triggered by request_module() now.

[    3.396467]  [<00000001f8d917e4>] call_usermodehelper_exec+0x44/0x1c8
[    3.396470]  [<00000001f8da5524>] __request_module+0x17c/0x3d0
[    3.396473]  [<00000001f93b4808>] crypto_alg_mod_lookup+0x228/0x290
[    3.396475]  [<00000001f93b4aae>] crypto_alloc_tfm_node+0x5e/0x158
[    3.396477]  [<00000001f93bbe14>] crypto_alloc_shash+0x34/0x40
[    3.396480]  [<00000001f93d2ee2>] drbg_init_hash_kernel+0x3a/0x100
[    3.396482]  [<00000001f93d306e>] drbg_alloc_state+0xc6/0x280
[    3.396484]  [<00000001f93d33d8>] drbg_kcapi_seed+0x1b0/0x310
[    3.396486]  [<00000001f93d1884>] crypto_rng_reset+0x5c/0xe0
[    3.396488]  [<00000001f93c1750>] alg_test_drbg+0x300/0x478
[    3.396490]  [<00000001f93c0934>] alg_test+0x304/0x530
[    3.396493]  [<00000001f93bedb8>] cryptomgr_test+0x68/0x70
[    3.396495]  [<00000001f8d9f40c>] kthread+0x14c/0x160
[    3.396497]  [<00000001f8d2af14>] __ret_from_fork+0x3c/0x58
[    3.396500]  [<00000001f984c86a>] ret_from_fork+0xa/0x30

Regards
Alex

  parent reply	other threads:[~2021-07-28 10:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13 21:25 [PATCH v3 0/2] background initramfs unpacking, and CONFIG_MODPROBE_PATH Rasmus Villemoes
2021-03-13 21:25 ` [PATCH v3 1/2] init/initramfs.c: do unpacking asynchronously Rasmus Villemoes
2021-03-15 20:21   ` Luis Chamberlain
2021-03-15 21:33   ` Andrew Morton
2021-03-15 21:59     ` Rasmus Villemoes
2021-07-24  7:46   ` Alexander Egorenkov
2021-07-26 11:46     ` Rasmus Villemoes
2021-07-27  7:31       ` Bruno Goncalves
2021-07-27 13:54         ` Luis Chamberlain
2021-07-27 14:12           ` Bruno Goncalves
2021-07-27 14:21             ` Luis Chamberlain
2021-07-27 14:27               ` Bruno Goncalves
2021-07-27 14:42                 ` Luis Chamberlain
2021-07-27 14:48                   ` Bruno Goncalves
2021-07-28 10:44                   ` Alexander Egorenkov
2021-07-28 10:38           ` Alexander Egorenkov
2021-07-28 10:36       ` Alexander Egorenkov [this message]
2021-07-28 11:49         ` Rasmus Villemoes
2021-03-13 21:25 ` [PATCH v3 2/2] modules: add CONFIG_MODPROBE_PATH Rasmus Villemoes
2021-03-15 20:06   ` Luis Chamberlain
2021-03-15 20:23 ` [PATCH v3 0/2] background initramfs unpacking, and CONFIG_MODPROBE_PATH Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfzyg1x9.fsf@oc8242746057.ibm.com \
    --to=egorenar@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bgoncalv@redhat.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dyoung@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mcgrof@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).