From: Michael Ellerman <mpe@ellerman.id.au>
To: "Paul A. Clarke" <pc@us.ibm.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@kernel.org, ananth@linux.vnet.ibm.com,
maddy@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com,
sukadev@linux.ibm.com, irogers@google.com
Subject: Re: [PATCH 2/2] perf: Add missing metrics to POWER9 'cpi_breakdown'
Date: Sat, 16 May 2020 22:03:19 +1000 [thread overview]
Message-ID: <87sgg09jeg.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200514210425.GA3338@oc3272150783.ibm.com>
"Paul A. Clarke" <pc@us.ibm.com> writes:
> On Wed, May 13, 2020 at 06:28:31PM +1000, Michael Ellerman wrote:
>> "Paul A. Clarke" <pc@us.ibm.com> writes:
>> > Add the following metrics to the POWER9 'cpi_breakdown' metricgroup:
>> > - ict_noslot_br_mpred_cpi
>> > - ict_noslot_br_mpred_icmiss_cpi
>> > - ict_noslot_cyc_other_cpi
>> > - ict_noslot_disp_held_cpi
>> > - ict_noslot_disp_held_hb_full_cpi
>> > - ict_noslot_disp_held_issq_cpi
>> > - ict_noslot_disp_held_other_cpi
>> > - ict_noslot_disp_held_sync_cpi
>> > - ict_noslot_disp_held_tbegin_cpi
>> > - ict_noslot_ic_l2_cpi
>> > - ict_noslot_ic_l3_cpi
>> > - ict_noslot_ic_l3miss_cpi
>> > - ict_noslot_ic_miss_cpi
>> >
>> > Signed-off-by: Paul A. Clarke <pc@us.ibm.com>
>> > ---
>> > .../arch/powerpc/power9/metrics.json | 143 ++++++++++--------
>> > 1 file changed, 78 insertions(+), 65 deletions(-)
>> >
>> > diff --git a/tools/perf/pmu-events/arch/powerpc/power9/metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/metrics.json
>> > index 811c2a8c1c9e..6169351a72c8 100644
>> > --- a/tools/perf/pmu-events/arch/powerpc/power9/metrics.json
>> > +++ b/tools/perf/pmu-events/arch/powerpc/power9/metrics.json
>> > @@ -207,6 +207,84 @@
>> > "MetricGroup": "cpi_breakdown",
>> > "MetricName": "fxu_stall_cpi"
>> > },
>> > + {
>> > + "BriefDescription": "Ict empty for this thread due to branch mispred",
>>
>> I think you're just moving this, not adding it. But ICT is an acronym,
>> so it should be spelled ICT not Ict.
>>
>> It might be worth expanding it too?
>
> This was 98% produced through automated means, translating an existing
> XML file to perf's JSON format.
>
> I've gotten the upstream XML file changed to include the "ICT" metrics
> in the "cpi_breakdown" group already, and can request the changes you
> suggest also be incorporated.
>
> For the time being, can we move forward with the patch as-is?
Fine by me.
cheers
prev parent reply other threads:[~2020-05-16 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 16:28 [PATCH 0/2] perf: Fix POWER9 cpi_breakdown metricgroup Paul A. Clarke
2020-05-07 16:28 ` [PATCH 1/2] perf: Fix POWER9 metric 'lsu_other_stall_cpi' Paul A. Clarke
2020-05-07 16:48 ` Arnaldo Carvalho de Melo
2020-05-07 17:21 ` Ian Rogers
2020-05-08 6:31 ` kajoljain
2020-05-08 7:01 ` kajoljain
2020-05-07 16:28 ` [PATCH 2/2] perf: Add missing metrics to POWER9 'cpi_breakdown' Paul A. Clarke
2020-05-07 16:57 ` Arnaldo Carvalho de Melo
2020-05-08 7:04 ` kajoljain
2020-05-10 6:26 ` Ian Rogers
2020-05-11 15:29 ` Arnaldo Carvalho de Melo
2020-05-13 8:28 ` Michael Ellerman
2020-05-14 21:04 ` Paul A. Clarke
2020-05-16 12:03 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgg09jeg.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=acme@kernel.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=pc@us.ibm.com \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).