From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: zhenwei pi <pizhenwei@bytedance.com>,
yelu@bytedance.com, libvir-list@redhat.com,
gregkh@linuxfoundation.org, qemu-devel@nongnu.org,
linux-kernel@vger.kernel.org, mprivozn@redhat.com
Subject: Re: [PATCH 1/2] pvpanic: introduce crashloaded for pvpanic
Date: Tue, 21 Jan 2020 14:38:58 +0100 [thread overview]
Message-ID: <87sgk9c4jx.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <247586dd-576a-a0c9-9c43-5d9a310a4ddc@redhat.com> (Paolo Bonzini's message of "Tue, 21 Jan 2020 11:50:53 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 21/01/20 09:22, Markus Armbruster wrote:
>> zhenwei pi <pizhenwei@bytedance.com> writes:
>>
>>> Add bit 1 for pvpanic. This bit means that guest hits a panic, but
>>> guest wants to handle error by itself. Typical case: Linux guest runs
>>> kdump in panic. It will help us to separate the abnormal reboot from
>>> normal operation.
>>>
>>> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
>>> ---
>>> docs/specs/pvpanic.txt | 8 ++++++--
>>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
>>> index c7bbacc778..bdea68a430 100644
>>> --- a/docs/specs/pvpanic.txt
>>> +++ b/docs/specs/pvpanic.txt
>>> @@ -16,8 +16,12 @@ pvpanic exposes a single I/O port, by default 0x505. On read, the bits
>>> recognized by the device are set. Software should ignore bits it doesn't
>>> recognize. On write, the bits not recognized by the device are ignored.
>>> Software should set only bits both itself and the device recognize.
>>
>> Guest software, I presume.
>>
>>> -Currently, only bit 0 is recognized, setting it indicates a guest panic
>>> -has happened.
>>> +
>>> +Bit Definition
>>> +--------------
>>> +bit 0: setting it indicates a guest panic has happened.
>>> +bit 1: named crashloaded. setting it indicates a guest panic and run
>>> + kexec to handle error by guest itself.
>>
>> Suggest to scratch "named crashloaded."
>
> bit 1: a guest panic has happened and will be handled by the guest;
> the host should record it or report it, but should not affect
> the execution of the guest.
>
> ?
>
> Paolo
Works for me, thanks!
next prev parent reply other threads:[~2020-01-21 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 10:06 [PATCH 0/2] implement crashloaded event for pvpanic zhenwei pi
2020-01-10 10:06 ` [PATCH 1/2] pvpanic: introduce crashloaded " zhenwei pi
2020-01-21 8:22 ` Markus Armbruster
2020-01-21 10:50 ` Paolo Bonzini
2020-01-21 13:38 ` Markus Armbruster [this message]
2020-01-10 10:06 ` [PATCH 2/2] pvpanic: implement crashloaded event handling zhenwei pi
2020-01-21 8:37 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgk9c4jx.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=libvir-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-devel@nongnu.org \
--cc=yelu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).