From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38057C4360C for ; Thu, 26 Sep 2019 01:10:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1486821A4A for ; Thu, 26 Sep 2019 01:10:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729321AbfIZBKF (ORCPT ); Wed, 25 Sep 2019 21:10:05 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:33241 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727374AbfIZBKE (ORCPT ); Wed, 25 Sep 2019 21:10:04 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1iDIIA-0005Bo-Ez; Wed, 25 Sep 2019 19:09:58 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1iDII8-0000OW-DU; Wed, 25 Sep 2019 19:09:58 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Jann Horn Cc: Andy Lutomirski , Theodore Tso , LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man References: <66b16acf2953fc033abc9641b9cf43d23e75a8e9.1568990048.git.luto@kernel.org> Date: Wed, 25 Sep 2019 20:09:26 -0500 In-Reply-To: (Jann Horn's message of "Tue, 24 Sep 2019 22:30:55 +0200") Message-ID: <87sgoj2795.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1iDII8-0000OW-DU;;;mid=<87sgoj2795.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/1fUlC8WTamoL7df9TU6CVtkUKkHX1bNM= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v2 7/7] random: Remove kernel.random.read_wakeup_threshold X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jann Horn writes: > On Fri, Sep 20, 2019 at 4:37 PM Andy Lutomirski wrote: >> It has no effect any more, so remove it. We can revert this if >> there is some user code that expects to be able to set this sysctl. >> >> Signed-off-by: Andy Lutomirski >> --- >> drivers/char/random.c | 18 +----------------- >> 1 file changed, 1 insertion(+), 17 deletions(-) >> >> diff --git a/drivers/char/random.c b/drivers/char/random.c > [...] >> - { >> - .procname = "read_wakeup_threshold", > > There's a line in bin_random_table in kernel/sysctl_binary.c that > refers to this sysctl, that should probably also be deleted? I think it should be safe to leave in kernel/sysctl_binary.c This reminds me. I think we may finally be at a point where we can remove practically all of kernel/sysctl_binary.c I need to double check but last I looked no distro enables COINFIG_SYSCTL_SYSCALL anymore. Ubunutu was the last distro I know of that enabled it, and I think it has been a year or more since Ubuntu disabled CONFIG_SYSCTL_SYSCALL. Eric