From: NeilBrown <neil@brown.name>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>,
linux-mtd@lists.infradead.org,
boris.brezillon@free-electrons.com, frieder.schrempf@exceet.de,
computersforpeace@gmail.com, david.wolfe@nxp.com, han.xu@nxp.com,
festevam@gmail.com, marek.vasut@gmail.com,
prabhakar.kushwaha@nxp.com, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: honour max_data_size for spi-nor writes
Date: Wed, 13 Jun 2018 08:24:26 +1000 [thread overview]
Message-ID: <87sh5riqxx.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20180612092248.4e6a3e92@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]
On Tue, Jun 12 2018, Boris Brezillon wrote:
>
> Just because you managed to solve the problem in one driver does not
> mean the problem does not exist for others. I read this datasheet [1]
> several times and couldn't find a way to say 'I want to keep the CS
> asserted between 2 transactions', so I think we really need this patch.
I agree that my experience doesn't necessarily generalize. As the patch
carried by signed-off-by (even though I only wrote little parts of it) I
wanted to make it clear that I had no desire to promote the patch -
maybe I stated that too strongly.
Thanks for the link to the data sheet. I had a bit of a look, but
reading these things must be an art that I haven't fully mastered yet -
it would probably take me a few days to really understand it.
The Programmable Sequence Enginine (Section 10.2.5.3.1) seems
interesting. I wouldn't be surprised that that lets you do interesting
things.
It is obviously quite a powerful unit and it is surprising - to me -
that it might not allow arbitrarily long messages, but I cannot justify
the time to really dig in and see if that is the case.
Maybe you are right. I have no particular objections to the patch, I
just don't want to be seen as speaking in favour of it.
Thanks,
NeilBrown
>
> Regards,
>
> Boris
>
> [1]https://www.nxp.com/docs/en/reference-manual/VFXXXRM.pdf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-06-12 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 9:18 [PATCH] mtd: spi-nor: honour max_data_size for spi-nor writes Yogesh Gaur
2018-06-11 9:49 ` Boris Brezillon
2018-06-11 22:05 ` NeilBrown
2018-06-12 7:22 ` Boris Brezillon
2018-06-12 22:24 ` NeilBrown [this message]
2018-06-12 22:35 ` Boris Brezillon
2018-06-13 6:14 ` Yogesh Narayan Gaur
2018-06-11 9:32 Yogesh Gaur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh5riqxx.fsf@notabene.neil.brown.name \
--to=neil@brown.name \
--cc=boris.brezillon@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=david.wolfe@nxp.com \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@exceet.de \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=prabhakar.kushwaha@nxp.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).