From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753311AbdDZR0w (ORCPT ); Wed, 26 Apr 2017 13:26:52 -0400 Received: from anholt.net ([50.246.234.109]:53864 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198AbdDZR0p (ORCPT ); Wed, 26 Apr 2017 13:26:45 -0400 From: Eric Anholt To: Florian Fainelli , Vivien Didelot , Andrew Lunn , netdev@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , Jon Mason Subject: Re: [PATCH v2 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT. In-Reply-To: <0cb00eb7-41d0-0390-4687-d966499ed9f4@gmail.com> References: <20170425235357.7690-1-eric@anholt.net> <20170425235357.7690-2-eric@anholt.net> <0cb00eb7-41d0-0390-4687-d966499ed9f4@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 26 Apr 2017 10:26:42 -0700 Message-ID: <87shkvjd0t.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Florian Fainelli writes: > On 04/25/2017 04:53 PM, Eric Anholt wrote: >> Cygnus has a single AMAC controller connected to the B53 switch with 2 >> PHYs. On the BCM911360_EP platform, those two PHYs are connected to >> the external ethernet jacks. >>=20 >> Signed-off-by: Eric Anholt >> Reviewed-by: Florian Fainelli >> --- >>=20 >> v2: Call the node "switch", just call the ports "port" (suggestions by >> Florian), drop max-speed on the phys (suggestion by Andrew Lunn), >> call the other nodes "ethernet" and "ethernet-phy" (suggestions by >> Sergei Shtylyov) >>=20 >> arch/arm/boot/dts/bcm-cygnus.dtsi | 58 +++++++++++++++++++++++++++= +++++++ >> arch/arm/boot/dts/bcm911360_entphn.dts | 8 +++++ >> 2 files changed, 66 insertions(+) >>=20 >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-c= ygnus.dtsi >> index 009f1346b817..9fd89be0f5e0 100644 >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi >> @@ -142,6 +142,54 @@ >> interrupts =3D <0>; >> }; >>=20=20 >> + mdio: mdio@18002000 { >> + compatible =3D "brcm,iproc-mdio"; >> + reg =3D <0x18002000 0x8>; >> + #size-cells =3D <1>; >> + #address-cells =3D <0>; > > Sorry for not noticing earlier, since you override this correctly in the > board-level DTS file can you put a: > > status =3D "disabled" > > property in there by default? I didn't have the override in the board file either, just switch and ethernet. Fixed. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlkA2FIACgkQtdYpNtH8 nuh9xxAAmJvaM8oLdXzmbYFLz9bZJHNAPHH4SJrANGQYV53BXHDGkv4OskYg18vp Xvz+zrFdlZDm9vim4v+9zvYs4Diaz+zYbP7WltWjVHX3/HfUijoBsfZAmJlSuBP4 nZPRM0ZoGoyjfsAU/hk1F1O95cv+kSi8HEVOLagS8qnlrfqbWC0oPyRjXy+BrvC/ /LPjlOVlLXW8+EPktr+17NTiSA0TTuGTROtCsnXHRsL1LF2t6Mpbwj+cD7x/FESs zScXVwREDFxOIKI+ZFh8PO2InhmiqjCbv1itZQUFUdKZ9pXt5BDW2g7NcpkWQZ2d PjnrLFSOSkTLskJU2danT0Jfie1GZOYZUwveH4VmBNl053zlARtyGPyy5tobFfqW cLZ4BIksRVZgeQL/X06SZl8sR8usIkJsnBE3BjjMXhWFJt9QBGPhe6faaeQ7FTJF n0gLaCqL7Gbs62QFz3jjYLdbLZ548C8UQ+5PhAkuz2W3qkRienG0y34K4aXZBBoG qj9cHJwPySM1DDw193O/uDSVn1LP8GlPfyeOQu2/ScGf9VAgBN8ijETfBq5SkPez iLTXpkF3rMeVp46rhHQf2fpSMrOsjuszPrdjZv0UwOrEcEY9VW1k9QCIjTFhCb7g TBQoHYx7thyA36DeBTBxOOnYDS0qhj8S49e5HQ9LgwMjIa/pgNo= =d24z -----END PGP SIGNATURE----- --=-=-=--