From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Sergey Yanovich <ynvich@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused
Date: Tue, 08 Nov 2016 18:30:43 +0100 [thread overview]
Message-ID: <87shr1yj3w.fsf@belgarion.home> (raw)
In-Reply-To: <20161108145130.3502815-2-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 8 Nov 2016 15:50:42 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> The fresh new serial driver for pxa produces warnings when
> CONFIG_PM_SLEEP is disabled:
>
> drivers/tty/serial/8250/8250_pxa.c:50:12: error: 'serial_pxa_resume' defined but not used [-Werror=unused-function]
> drivers/tty/serial/8250/8250_pxa.c:41:12: error: 'serial_pxa_suspend' defined but not used [-Werror=unused-function]
>
> This removes the #ifdef around the two functions and instead marks both
> as __maybe_unused, which is more robust and avoids the warning.
>
> Fixes: ab28f51c77cd ("serial: rewrite pxa2xx-uart to use 8250_core")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
prev parent reply other threads:[~2016-11-08 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 14:50 [PATCH 1/2] serial: pxa2xx: remove __deprecated annotation Arnd Bergmann
2016-11-08 14:50 ` [PATCH 2/2] serial: pxa2xx: mark PM functions as __maybe_unused Arnd Bergmann
2016-11-08 17:30 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shr1yj3w.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).