From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932808AbcITKHk (ORCPT ); Tue, 20 Sep 2016 06:07:40 -0400 Received: from mga03.intel.com ([134.134.136.65]:55825 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932560AbcITKHj (ORCPT ); Tue, 20 Sep 2016 06:07:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,367,1470726000"; d="scan'208";a="1059418161" From: Jani Nikula To: SF Markus Elfring , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Patrik Jakobsson Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data() In-Reply-To: <287833f5-f1ad-b7f0-c614-d4c903b1c890@users.sourceforge.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <566ABCD9.1060404@users.sourceforge.net> <3c9785ef-4553-2e3d-2cb2-5cf6d1f31ccd@users.sourceforge.net> <287833f5-f1ad-b7f0-c614-d4c903b1c890@users.sourceforge.net> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 20 Sep 2016 13:07:35 +0300 Message-ID: <87shsulw9k.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 20 Sep 2016 10:36:19 +0200 > > A single error message should be sufficient to inform about > the detection of an unknown GCT revision at the end. > Thus return after the logging call in this case directly. Did you test this? BR, Jani. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/gma500/mid_bios.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c > index 9004d30..e5cece0 100644 > --- a/drivers/gpu/drm/gma500/mid_bios.c > +++ b/drivers/gpu/drm/gma500/mid_bios.c > @@ -320,6 +320,7 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv) > break; > default: > dev_err(dev->dev, "Unknown revision of GCT!\n"); > + return; > } > > out: -- Jani Nikula, Intel Open Source Technology Center