From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbcDMUpX (ORCPT ); Wed, 13 Apr 2016 16:45:23 -0400 Received: from albireo.enyo.de ([46.237.207.196]:42518 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbcDMUpV (ORCPT ); Wed, 13 Apr 2016 16:45:21 -0400 From: Florian Weimer To: "H. Peter Anvin" Cc: "Richard W.M. Jones" , linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, luto@kernel.org, viro@zeniv.linux.org.uk, mathieu.desnoyers@efficios.com, zab@redhat.com, paulmck@linux.vnet.ibm.com, aarcange@redhat.com, josh@joshtriplett.org, xemul@parallels.com, sfr@canb.auug.org.au, milosz@adfin.com, rostedt@goodmis.org, arnd@arndb.de, ebiederm@xmission.com, gorcunov@openvz.org, iulia.manda21@gmail.com, dave.hansen@linux.intel.com, mguzik@redhat.com, adobriyan@gmail.com, dave@stgolabs.net, linux-api@vger.kernel.org, gorcunov@gmail.com, walters@verbum.org Subject: Re: [PATCH v4 0/3] vfs: Define new syscall umask2 [formerly getumask] References: <1460574336-18930-1-git-send-email-rjones@redhat.com> <570EA006.5010608@zytor.com> Date: Wed, 13 Apr 2016 22:45:05 +0200 In-Reply-To: <570EA006.5010608@zytor.com> (H. Peter Anvin's message of "Wed, 13 Apr 2016 12:37:42 -0700") Message-ID: <87shypck6m.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * H. Peter Anvin: > I have to say I'm skeptic to the need for umask2() as opposed to > getumask(). I find the extension with a set-the-thread umask somewhat unlikely. How would a potential per-thread umask interact with CLONE_FS? Have a per-thread umask that, when active, overrides the global one, similar to what uselocale provides? That seems rather messy, and I'm not aware of any precedent.