From: "Bjørn Mork" <bjorn@mork.no>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-kernel@vger.kernel.org,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>, "Lan\,
Tianyu" <tianyu.lan@intel.com>
Subject: Re: BUG: unable to handle kernel paging request in usb_match_id()
Date: Fri, 17 Aug 2012 11:07:21 +0200 [thread overview]
Message-ID: <87sjblnaye.fsf@nemi.mork.no> (raw)
In-Reply-To: <87wr0xnbnm.fsf@nemi.mork.no> (=?utf-8?Q?=22Bj=C3=B8rn?= Mork"'s message of "Fri, 17 Aug 2012 10:52:13 +0200")
Bjørn Mork <bjorn@mork.no> writes:
> Fengguang Wu <fengguang.wu@intel.com> writes:
>
>> @@ -779,6 +780,7 @@ static int usb_device_match(struct devic
>> intf = to_usb_interface(dev);
>> usb_drv = to_usb_driver(drv);
>>
>> + pr_info("%s: device %s, driver %s \n", __func__, dev_name(dev), drv->name);
>> id = usb_match_id(intf, usb_drv->id_table);
>> if (id)
>> return 1;
>> [ 1.397745] usb_match_id: id=c1d80820 idVendor=0x18f3 idProduct=0x220
>> [ 1.398834] usbcore: registered new interface driver dvb_usb_dtt200u
>> [ 1.399943] usb_device_match: device 1-0:1.0, driver dvb_usb_nova_t_usb2
>> [ 1.401095] usb_match_id: id=c1d81b6c idVendor=0x2040 idProduct=0x9300
>> [ 1.402195] usb_match_id: id=c1d81b84 idVendor=0x2040 idProduct=0x9301
>> [ 1.403270] usbcore: registered new interface driver dvb_usb_nova_t_usb2
>> [ 1.404158] usb_device_match: device 1-0:1.0, driver dvb_usb_umt_010
>> [ 1.404861] usb_match_id: id=c1d824f4 idVendor=0x15f4 idProduct=0x1
>> [ 1.405547] usb_match_id: id=c1d8250c idVendor=0x15f4 idProduct=0x15
>> [ 1.406326] usbcore: registered new interface driver dvb_usb_umt_010
>> [ 1.407190] usb_device_match: device 1-0:1.0, driver dvb_usb_gl861
>
> Why is dev_name(dev) constant here? That seems more than odd to me. Is
> this really the same interface matching all these drivers?
Stupid me didn't read your debugging printk's properly. You are of
course logging this *before* testing for a match, so everything is as
expected.
But looking at the emi62 driver, I wonder if this will make any
difference:
diff --git a/drivers/usb/misc/emi62.c b/drivers/usb/misc/emi62.c
index ff08015..ae794b9 100644
--- a/drivers/usb/misc/emi62.c
+++ b/drivers/usb/misc/emi62.c
@@ -232,7 +232,7 @@ wraperr:
return err;
}
-static const struct usb_device_id id_table[] __devinitconst = {
+static const struct usb_device_id id_table[] = {
{ USB_DEVICE(EMI62_VENDOR_ID, EMI62_PRODUCT_ID) },
{ } /* Terminating entry */
};
Bjørn
next prev parent reply other threads:[~2012-08-17 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 2:59 BUG: unable to handle kernel paging request in usb_match_id() Fengguang Wu
2012-08-05 16:58 ` Greg Kroah-Hartman
2012-08-17 2:00 ` Fengguang Wu
2012-08-17 3:48 ` Greg Kroah-Hartman
2012-08-17 5:44 ` Fengguang Wu
2012-08-17 8:52 ` Bjørn Mork
2012-08-17 9:07 ` Bjørn Mork [this message]
2012-08-17 9:27 ` Fengguang Wu
2012-08-17 10:24 ` Fengguang Wu
2012-08-17 12:16 ` Ming Lei
2012-08-17 13:45 ` Greg Kroah-Hartman
2012-08-17 14:38 ` Alan Stern
2012-08-17 14:42 ` Greg Kroah-Hartman
2012-08-18 0:58 ` Ming Lei
2012-08-19 10:23 ` Bjørn Mork
2012-08-19 14:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjblnaye.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).