From: "Björn Töpel" <bjorn@kernel.org>
To: Liu Shixin <liushixin2@huawei.com>,
Conor Dooley <conor@kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org,
Liu Shixin <liushixin2@huawei.com>
Subject: Re: [PATCH v2 0/2] riscv: Support HAVE_ARCH_HUGE_VMAP and HAVE_ARCH_HUGE_VMALLOC
Date: Tue, 11 Oct 2022 14:39:44 +0200 [thread overview]
Message-ID: <87tu4ah6un.fsf@smulpajen.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20221008140506.1066805-1-liushixin2@huawei.com>
Liu Shixin <liushixin2@huawei.com> writes:
> Since riscv64 has already support SATP_MODE_57 by default, it is time to
> support more hugepage-related features. These two patches will enable
> HAVE_ARCH_HUGE_VMAP and HAVE_ARCH_HUGE_VMALLOC.
>
Just a note; The HP support does not require sv57. Pmd/Mega- and
pud/gigapages work for sv39 and sv48 as well.
> v1->v2: Fix the build error reported by kernel-test.
>
> Liu Shixin (2):
> riscv: Enable HAVE_ARCH_HUGE_VMAP for 64BIT
> riscv: Enable HAVE_ARCH_HUGE_VMALLOC for 64BIT
>
> .../features/vm/huge-vmap/arch-support.txt | 2 +-
> arch/riscv/Kconfig | 2 +
> arch/riscv/include/asm/vmalloc.h | 18 ++++
> arch/riscv/mm/Makefile | 1 +
> arch/riscv/mm/pgtable.c | 83 +++++++++++++++++++
> 5 files changed, 105 insertions(+), 1 deletion(-)
> create mode 100644 arch/riscv/mm/pgtable.c
>
I've taken this series for a spin, and tested huge pud pages via
ioremap(), and huge pmd pages via vmalloc_huge() on qemu for sv39, sv48,
and sv57.
Patch 2 have a spelling error in the commit message: "enbale" vs
"enable".
Fix up the spelling error in patch 2, and after that feel free to add
for the whole series:
Reviewed-by: Björn Töpel <bjorn@kernel.org>
Tested-by: Björn Töpel <bjorn@kernel.org>
Nice work!
Björn
next prev parent reply other threads:[~2022-10-11 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 14:05 [PATCH v2 0/2] riscv: Support HAVE_ARCH_HUGE_VMAP and HAVE_ARCH_HUGE_VMALLOC Liu Shixin
2022-10-08 14:05 ` [PATCH v2 1/2] riscv: Enable HAVE_ARCH_HUGE_VMAP for 64BIT Liu Shixin
2022-10-08 14:05 ` [PATCH v2 2/2] riscv: Enable HAVE_ARCH_HUGE_VMALLOC " Liu Shixin
2022-10-11 12:39 ` Björn Töpel [this message]
2022-10-12 2:47 ` [PATCH v2 0/2] riscv: Support HAVE_ARCH_HUGE_VMAP and HAVE_ARCH_HUGE_VMALLOC Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu4ah6un.fsf@smulpajen.i-did-not-set--mail-host-address--so-tickle-me \
--to=bjorn@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=liushixin2@huawei.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).