From: Marc Zyngier <maz@kernel.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
bjorn.andersson@linaro.org, linus.walleij@linaro.org,
tkjos@google.com, lsrao@codeaurora.org
Subject: Re: [PATCH 2/2] irqchip: qcom-pdc: Disconnect domain hierarchy for GPIO_NO_WAKE_IRQs
Date: Wed, 18 Aug 2021 10:31:04 +0100 [thread overview]
Message-ID: <87tujnrtev.wl-maz@kernel.org> (raw)
In-Reply-To: <1629195546-27811-2-git-send-email-mkshah@codeaurora.org>
Hi Maulik,
In the future, please always add a cover-letter email if sending a
series that has more than a single patch. This considerably helps the
tracking, and gives you an opportunity to explain what you are doing.
On Tue, 17 Aug 2021 11:19:06 +0100,
Maulik Shah <mkshah@codeaurora.org> wrote:
>
> gpio_to_irq() reports error at irq_domain_trim_hierarchy() for non wakeup
> capable GPIOs that do not have dedicated interrupt at GIC.
>
> Since PDC irqchip do not allocate irq at parent GIC domain for such GPIOs
> indicate same by using irq_domain_disconnect_hierarchy().
>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> ---
> drivers/irqchip/qcom-pdc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> index 32d5920..0ba0461 100644
> --- a/drivers/irqchip/qcom-pdc.c
> +++ b/drivers/irqchip/qcom-pdc.c
> @@ -324,8 +324,11 @@ static int qcom_pdc_gpio_alloc(struct irq_domain *domain, unsigned int virq,
> if (ret)
> return ret;
>
> - if (hwirq == GPIO_NO_WAKE_IRQ)
> + if (hwirq == GPIO_NO_WAKE_IRQ) {
> + if (domain->parent)
> + irq_domain_disconnect_hierarchy(domain->parent, virq);
> return 0;
> + }
>
> parent_hwirq = get_parent_hwirq(hwirq);
> if (parent_hwirq == PDC_NO_PARENT_IRQ)
It feels like you are papering over the core of the problem, which is
that most of the GPIO_NO_WAKE_IRQ stuff should simply go away now that
we have a way to drop parts of the hierarchy.
I had a go at that a few months back, but never had the opportunity to
actually test the resulting code[1]. Could you please give it a go and
let me know what breaks?
Thanks,
M.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/qcom-pdc-nowake&id=331b2ba388a4a79b5c40b8addf56cbe35099a410
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-08-18 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 10:19 [PATCH 1/2] irqdomain: Export irq_domain_disconnect_hierarchy() Maulik Shah
2021-08-17 10:19 ` [PATCH 2/2] irqchip: qcom-pdc: Disconnect domain hierarchy for GPIO_NO_WAKE_IRQs Maulik Shah
2021-08-18 9:31 ` Marc Zyngier [this message]
2021-08-19 11:35 ` Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tujnrtev.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mkshah@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).