* [PATCH] usb: dwc3: remove repeated setting of current_dr_role
@ 2021-05-06 7:26 Chunfeng Yun
2021-05-06 8:54 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Chunfeng Yun @ 2021-05-06 7:26 UTC (permalink / raw)
To: Felipe Balbi
Cc: Greg Kroah-Hartman, Matthias Brugger, linux-usb, linux-kernel,
linux-arm-kernel, linux-mediatek, Chunfeng Yun
dwc3_set_prtcap() already sets current_dr_role as
DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/dwc3/drd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index e2b68bb770d1..8fcbac10510c 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -596,7 +596,6 @@ int dwc3_drd_init(struct dwc3 *dwc)
dwc3_drd_update(dwc);
} else {
dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
- dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;
/* use OTG block to get ID event */
irq = dwc3_otg_get_irq(dwc);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3: remove repeated setting of current_dr_role
2021-05-06 7:26 [PATCH] usb: dwc3: remove repeated setting of current_dr_role Chunfeng Yun
@ 2021-05-06 8:54 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2021-05-06 8:54 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Greg Kroah-Hartman, Matthias Brugger, linux-usb, linux-kernel,
linux-arm-kernel, linux-mediatek, Chunfeng Yun
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
Hi,
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> dwc3_set_prtcap() already sets current_dr_role as
> DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
looks correct to me:
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-06 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 7:26 [PATCH] usb: dwc3: remove repeated setting of current_dr_role Chunfeng Yun
2021-05-06 8:54 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).