From: Thomas Gleixner <tglx@linutronix.de>
To: Oleksandr Natalenko <oleksandr@natalenko.name>
Cc: bugzilla-daemon@bugzilla.kernel.org, jdelvare@suse.de,
wsa@kernel.org, benjamin.tissoires@redhat.com,
rui.zhang@intel.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Carlos Jimenez <javashin1986@gmail.com>
Subject: Re: [Bug 202453] TRACE irq/18-i801_smb Tainted when enabled threadirqs in kernel commandline.
Date: Sat, 05 Dec 2020 19:59:46 +0100 [thread overview]
Message-ID: <87tut084f1.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201205162403.sey33v2js2cs65q4@spock.localdomain>
On Sat, Dec 05 2020 at 17:24, Oleksandr Natalenko wrote:
> On Sat, Dec 05, 2020 at 05:19:18PM +0100, Thomas Gleixner wrote:
>> +/**
>> + * generic_dispatch_irq - Dispatch an interrupt from an interrupt handler
>> + * @irq: The irq number to handle
>> + *
>> + * A wrapper around generic_handle_irq() which ensures that interrupts are
>> + * disabled when the primary handler of the dispatched irq is invoked.
>> + * This is useful for interrupt handlers with dispatching to be safe for
>> + * the forced threaded case.
>> + */
>> +int generic_dispatch_irq(unsigned int irq)
>> +{
>> + unsigned long flags;
>> + int ret;
>> +
>> + local_irq_save(&flags);
>> + ret = generic_handle_irq(irq);
>> + local_irq_restore(&flags);
>
> FWIW, for me &flags explodes build on v5.10-rc6. I had to change it to local_irq_save/restore(flags) (without taking an address via &).
That's right. Don't know what I was thinking when writing it and then
compiling with the patch removed (just checked history ...) Oh, well
next prev parent reply other threads:[~2020-12-05 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-202453-19117@https.bugzilla.kernel.org/>
[not found] ` <bug-202453-19117-0k1QQBMPTi@https.bugzilla.kernel.org/>
2020-12-04 20:19 ` [Bug 202453] TRACE irq/18-i801_smb Tainted when enabled threadirqs in kernel commandline Oleksandr Natalenko
2020-12-05 16:19 ` Thomas Gleixner
2020-12-05 16:24 ` Oleksandr Natalenko
2020-12-05 18:59 ` Thomas Gleixner [this message]
2020-12-05 20:19 ` genirq, i2c: Provide and use generic_dispatch_irq() kernel test robot
2020-12-05 20:19 ` kernel test robot
2020-12-05 21:27 ` kernel test robot
2021-01-04 20:58 ` [Bug 202453] TRACE irq/18-i801_smb Tainted when enabled threadirqs in kernel commandline Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tut084f1.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=benjamin.tissoires@redhat.com \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=javashin1986@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oleksandr@natalenko.name \
--cc=peterz@infradead.org \
--cc=rui.zhang@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).