From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31AE8C2D0DB for ; Sat, 25 Jan 2020 10:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F34512070A for ; Sat, 25 Jan 2020 10:34:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="m6c5oEoK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbgAYKeO (ORCPT ); Sat, 25 Jan 2020 05:34:14 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:52565 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgAYKeN (ORCPT ); Sat, 25 Jan 2020 05:34:13 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 484XS24lytz9sRf; Sat, 25 Jan 2020 21:34:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1579948451; bh=AJPU8Hs6GFSApjSXAcOPRu/GO9Tc3s9+wbfyn6Clkrk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=m6c5oEoKbKQhdcjjPmW9TkV+VkwNGbsJaGAeyyYLSgUf+heWju2xk7X6Ybz1yuZgN 2U3Tfgap8+AMnLMF5XCvsj7YU61913Rvo0eYQpUKQIOmLP5x/xqAVbNboD90wtkgFD 0L2EliyejJ1qcY/6lThw9dC64978raDnMgqHsMGcuN4Xw96ikCNghs45GkMOIKgsDN BkdCVuROWMZCpqIj6jkobw/5VqAG+uKL/XdhqVqMcbAwTM6QILY4LsZGmvkNFHSXwR FmvMEEYsJact3sNOequMRbv3BQr1lE9JnXyOVNPNHw2uQstSG/8a/1qY8ew6BaQBle tAqc+igl/dFdw== From: Michael Ellerman To: Nick Desaulniers , Peter Zijlstra Cc: Will Deacon , LKML , linux-arch , kernel-team , Linus Torvalds , Segher Boessenkool , Christian Borntraeger , Luc Van Oostenryck , Arnd Bergmann , Peter Oberparleiter , Masahiro Yamada Subject: Re: [PATCH v2 09/10] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8 In-Reply-To: References: <20200123153341.19947-1-will@kernel.org> <20200123153341.19947-10-will@kernel.org> <20200124082637.GZ14914@hirez.programming.kicks-ass.net> Date: Sat, 25 Jan 2020 21:34:10 +1100 Message-ID: <87tv4jhljx.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nick Desaulniers writes: > On Fri, Jan 24, 2020 at 12:26 AM Peter Zijlstra wrote: >> On Thu, Jan 23, 2020 at 10:36:37AM -0800, Nick Desaulniers wrote: >> > On Thu, Jan 23, 2020 at 7:34 AM Will Deacon wrote: >> > > It is very rare to see versions of GCC prior to 4.8 being used to build >> > > the mainline kernel. These old compilers are also know to have codegen >> > > issues which can lead to silent miscompilation: >> > > >> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 >> > > >> > > Raise the minimum GCC version for kernel build to 4.8 and remove some >> > > tautological Kconfig dependencies as a consequence. >> > > >> > > Cc: Nick Desaulniers >> > >> > Thanks for the patch. >> > Reviewed-by: Nick Desaulniers >> > I wouldn't mind if this patch preceded the earlier one in the series >> > adding the warning, should the series require a v2 and if folks are >> > generally ok with bumping the min version. >> >> If I hadn't actually read your reply, I would have never spotted that >> reviewed-by tag, hidden in a blob of text like that. >> >> Adding some whitespace before and after, such that it stands out a >> little more, might avoid such issues. > > Ack. Do maintainers have tools for fetching patch series and > automating collecting Reviewed-by tags, or is it all extremely manual? Patchwork collects them for you. But not all maintainers use patchwork, it's a bit new and trendy ;) cheers