From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Christopher S Hall <christopher.s.hall@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PTP: introduce new versions of IOCTLs
Date: Fri, 30 Aug 2019 10:57:55 +0300 [thread overview]
Message-ID: <87tv9zulto.fsf@gmail.com> (raw)
In-Reply-To: <20190829172113.GA2166@localhost>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
Hi,
Richard Cochran <richardcochran@gmail.com> writes:
>> @@ -139,11 +141,24 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
>> break;
>>
>> case PTP_EXTTS_REQUEST:
>> + case PTP_EXTTS_REQUEST2:
>> + memset(&req, 0, sizeof(req));
>> +
>> if (copy_from_user(&req.extts, (void __user *)arg,
>> sizeof(req.extts))) {
>> err = -EFAULT;
>> break;
>> }
>> + if ((req.extts.flags || req.extts.rsv[0] || req.extts.rsv[1])
>> + && cmd == PTP_EXTTS_REQUEST2) {
>> + err = -EINVAL;
>> + break;
>> + } else if (cmd == PTP_EXTTS_REQUEST) {
>> + req.extts.flags = 0;
>
> This still isn't quite right. Sorry that was my fault.
>
> The req.extts.flags can be (PTP_ENABLE_FEATURE | PTP_RISING_EDGE |
> PTP_FALLING_EDGE), and ENABLE is used immediately below in this case.
>
> Please #define those bits into a valid mask, and then:
>
> - for PTP_EXTTS_REQUEST2 check that ~mask is zero, and
> - for PTP_EXTTS_REQUEST clear the ~mask bits for the drivers.
>
> Thanks again for cleaning this up!
good point. This will actually reduce the size of the patch 2.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-08-30 7:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 9:58 [PATCH v2 1/2] PTP: introduce new versions of IOCTLs Felipe Balbi
2019-08-29 9:58 ` [PATCH v2 2/2] PTP: add support for one-shot output Felipe Balbi
2019-08-29 17:25 ` Richard Cochran
2019-08-29 17:28 ` Richard Cochran
2019-08-30 8:00 ` Felipe Balbi
2019-08-31 14:47 ` Richard Cochran
2019-09-05 10:03 ` Felipe Balbi
2019-09-06 5:35 ` Richard Cochran
2019-08-31 15:01 ` Richard Cochran
2019-09-05 10:40 ` Felipe Balbi
2019-08-29 17:21 ` [PATCH v2 1/2] PTP: introduce new versions of IOCTLs Richard Cochran
2019-08-30 7:57 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv9zulto.fsf@gmail.com \
--to=felipe.balbi@linux.intel.com \
--cc=christopher.s.hall@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).